Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postal code (zip code) for Canada should allow postal codes without space #13899

Closed
sl02 opened this issue Mar 1, 2018 · 6 comments
Closed

Postal code (zip code) for Canada should allow postal codes without space #13899

sl02 opened this issue Mar 1, 2018 · 6 comments
Assignees
@tadeobarranco
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs

Comments

@sl02
Copy link

sl02 commented Mar 1, 2018

This is practically a copy-paste of issue #11898, which was for Netherlands.

Issue

Zip code validation warning on adresses from Canada.
Current validation is A1B 2C3
This should also allow postal code without space A1B2C3

Preconditions

Tested only on 2.2.

Steps to reproduce

Go to cart or checkout, select Canada and insert postal code A1B2C3

Expected result

No warning

Actual result

Zipcode gives warning

Additional info:
Like in issue #11898, even though having the space is the official format, having no space is still widely accepted and common. Should definitely not trigger an error.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 1, 2018
@magento-engcom-team
Copy link
Contributor

@sl02, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs labels Mar 1, 2018
@tadeobarranco
Copy link
Contributor

#MageTitansMX

@magento-engcom-team
Copy link
Contributor

@tadeobarranco thank you for joining. Please accept team invitation here and self-assign the issue.

tadeobarranco added a commit to magentomxcommunity/magento2 that referenced this issue Mar 2, 2018
@tadeobarranco
magento#13899 Solve Zipcode pattern for Canada
c6d128f
tadeobarranco added a commit to magentomxcommunity/magento2 that referenced this issue Mar 2, 2018
@tadeobarranco
magento#13899 Improve unit test
7c5ddee
tadeobarranco added a commit to magentomxcommunity/magento2 that referenced this issue Mar 2, 2018
@tadeobarranco
magento#13899 Improve unit test
fa8b884
@tadeobarranco tadeobarranco mentioned this issue Mar 2, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @sl02. Thank you for your report.
The issue has been fixed in #13930 by @tadeobarranco in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 7, 2018
magento-engcom-team added a commit that referenced this issue Mar 7, 2018
@magento-engcom-team
ENGCOM-696: #13899 Solve Canada Zip Code pattern #13930
4343d86 
 - Merge Pull Request #13930 from magentomxcommunity/magento2:issue#13899
 - Merged commits:
   1. c6d128f
   2. 7c5ddee
   3. fa8b884
   4. 8fae90b
magento-engcom-team pushed a commit that referenced this issue Mar 7, 2018
ENGCOM-696: #13899 Solve Canada Zip Code pattern #13930
ce9fba4
@AlexWorking AlexWorking mentioned this issue Mar 20, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @sl02. Thank you for your report.
The issue has been fixed in #14215 by @AlexWorking in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 21, 2018
magento-engcom-team added a commit that referenced this issue Mar 21, 2018
@magento-engcom-team
ENGCOM-993: [Forwardport] #13899 Solve Canada Zip Code pattern #14215
087eabc 
 - Merge Pull Request #14215 from AlexWorking/magento2:2.3-develop-PR-port-13930
 - Merged commits:
   1. c87b104
   2. ac37727
   3. bda63c7
   4. cb04f93
magento-engcom-team pushed a commit that referenced this issue Mar 21, 2018
ENGCOM-993: [Forwardport] #13899 Solve Canada Zip Code pattern #14215
53aa779
hitesh-wagento pushed a commit to hitesh-wagento/magento2 that referenced this issue Jun 12, 2018
@tadeobarranco @hitesh-wagento
magento#13899 Solve Zipcode pattern for Canada
bc26a3a
hitesh-wagento pushed a commit to hitesh-wagento/magento2 that referenced this issue Jun 12, 2018
@tadeobarranco @hitesh-wagento
magento#13899 Improve unit test
8f03ac9
hitesh-wagento pushed a commit to hitesh-wagento/magento2 that referenced this issue Jun 12, 2018
@tadeobarranco @hitesh-wagento
magento#13899 Improve unit test
2587e0f
@hitesh-wagento hitesh-wagento mentioned this issue Jun 12, 2018
Merged
4 tasks
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Jun 12, 2018
@hitesh-wagento
Merge pull request #12 from hitesh-wagento/2.1-develop-PR-port-13930
fc130fd 
[Backport] magento#13899 Solve Canada Zip Code pattern
@hitesh-wagento hitesh-wagento mentioned this issue Jun 12, 2018
Merged
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Jun 13, 2018

Hi @sl02. Thank you for your report.
The issue has been fixed in #16031 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 13, 2018
magento-engcom-team added a commit that referenced this issue Jun 13, 2018
@magento-engcom-team
ENGCOM-1948: [Backport] #13899 Solve Canada Zip Code pattern #16031
112fb84 
 - Merge Pull Request #16031 from hitesh-wagento/magento2:2.1-develop-PR-port-13930
 - Merged commits:
   1. bc26a3a
   2. 8f03ac9
   3. 2587e0f
   4. e7db130
magento-engcom-team pushed a commit that referenced this issue Jun 13, 2018
ENGCOM-1948: [Backport] #13899 Solve Canada Zip Code pattern #16031
486e92c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadeobarranco tadeobarranco

Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tadeobarranco @sidolov @sl02 @magento-engcom-team