Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #13899 Solve Canada Zip Code pattern #12

Merged
merged 44 commits into from
Jun 12, 2018

Conversation

hitesh-wagento
Copy link
Owner

Original Pull Request

magento#13930
Add new pattern to validate Canada Zip Codes

Description

Change pattern validation for Canada Zip Codes

Fixed Issues (if relevant)

  1. Postal code (zip code) for Canada should allow postal codes without space magento/magento2#13899: Postal code (zip code) for Canada should allow postal codes without space

Manual testing scenarios

  1. Add Product to Cart
  2. Go to shopping cart
  3. Select Canda Country
  4. Put ZipCode: A1B2C3

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

VitaliyBoyko and others added 30 commits May 17, 2018 22:17
…5290

 - Merge Pull Request magento#15290 from VitaliyBoyko/magento2:Fix-typo-in-database-column-comment
 - Merged commits:
   1. bf18e7a
 - Merge Pull Request magento#15866 from dmytro-ch/magento2:2.1-develop-PR-port-15845
 - Merged commits:
   1. 228b765
…les magento#15887

 - Merge Pull Request magento#15887 from rahul-kachhadiya/magento2:2.1-develop-PR-port-15371
 - Merged commits:
   1. 6ab1020
 - Merge Pull Request magento#15920 from DanielRuf/magento2:2.1-develop-PR-port-15871
 - Merged commits:
   1. fc35b01
…s list magento#15924

 - Merge Pull Request magento#15924 from dmytro-ch/magento2:2.1-develop-PR-port-14473
 - Merged commits:
   1. 6c6d67f
 - Merge Pull Request magento#15925 from dmytro-ch/magento2:2.1-develop-PR-port-14358
 - Merged commits:
   1. 6027744
…15926

 - Merge Pull Request magento#15926 from dmytro-ch/magento2:2.1-develop-PR-port-14350
 - Merged commits:
   1. 6257807
…ento#15927

 - Merge Pull Request magento#15927 from dmytro-ch/magento2:2.1-develop-PR-port-14306
 - Merged commits:
   1. 0658873
Accepted Public Pull Requests:
 - magento#15927: [Backport]  [magento#14089] Add Malaysian Locale Code (by @dmytro-ch)
 - magento#15926: [Backport] precision for price overriding by js (by @dmytro-ch)
 - magento#15925: [Backport] Format code (by @dmytro-ch)
 - magento#15924: [Backport] Added spanish Bolivia locale to allowedLocales list (by @dmytro-ch)
 - magento#15920: [Backport] chore: remove unused less import (by @DanielRuf)
 - magento#15887: [Backport-2.1] Added language translation in template files (by @rahul-kachhadiya)
 - magento#15866: [Backport] Update webapi.xml to fix typo (by @dmytro-ch)
 - magento#15290: [Backport] Fix typo in database column comment (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento#14089: Malaysian (Malaysia) missing from locale list (reported by @superdav42) has been fixed in magento#15927 by @dmytro-ch in 2.1-develop branch
   Related commits:
     1. 0658873

 - magento#14249: Priduct page price is using the hardcoded digits in js (reported by @cdiacon) has been fixed in magento#15926 by @dmytro-ch in 2.1-develop branch
   Related commits:
     1. 6257807
…agento#15933

 - Merge Pull Request magento#15933 from rogyar/magento2:2.1-empty-anchors-fix
 - Merged commits:
   1. 4caef44
Saurabh Parekh and others added 14 commits June 8, 2018 04:45
Accepted Public Pull Requests:
 - magento#15933: Do not display anchor if admin submenu has no children (by @rogyar)
…inition does not requir… magento#15949

 - Merge Pull Request magento#15949 from saurabh-aureate/magento2:2.1-develop-PR-port-15891
 - Merged commits:
   1. 063840f
…chCriteria - added zero … magento#15945

 - Merge Pull Request magento#15945 from vgelani/magento2:2.1-develop-PR-port-15322
 - Merged commits:
   1. f3108a3
…rnal\Magento\Framework\D… magento#15943

 - Merge Pull Request magento#15943 from vgelani/magento2:2.1-develop-PR-port-15892
 - Merged commits:
   1. 63ebb61
   2. 3c58390
Accepted Public Pull Requests:
 - magento#15943: [Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D� (by @vgelani)
 - magento#15945: [Backport] ISSUE-11477 - fixed Swagger response for searchCriteria - added zero � (by @vgelani)
 - magento#15949: [Backport]No need to pass method parameter as method definition does not requir� (by @saurabh-aureate)


Fixed GitHub Issues:
 - magento#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria (reported by @careys7) has been fixed in magento#15945 by @vgelani in 2.1-develop branch
   Related commits:
     1. f3108a3
@hitesh-wagento hitesh-wagento merged commit fc130fd into 2.1-develop Jun 12, 2018
hitesh-wagento pushed a commit that referenced this pull request Jul 14, 2018
[Forwardport] Prevent servers being slammed from many search suggestion requests
@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-13930 branch September 6, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.