Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #13899 Solve Canada Zip Code pattern #16031

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#13930
Add new pattern to validate Canada Zip Codes

Description

Change pattern validation for Canada Zip Codes

Fixed Issues (if relevant)

  1. Postal code (zip code) for Canada should allow postal codes without space #13899: Postal code (zip code) for Canada should allow postal codes without space

Manual testing scenarios

  1. Add Product to Cart
  2. Go to shopping cart
  3. Select Canda Country
  4. Put ZipCode: A1B2C3

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@hitesh-wagento
Copy link
Contributor Author

Hi @magento-engcom-team, @sidolov

Could you please add Back port/Up port label in this PR and which upcoming version it will release because still didn't get points this PR.

Thanks

@sidolov
Copy link
Contributor

sidolov commented Jun 14, 2018

Hi @hitesh-wagento . Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-13930 branch September 6, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants