-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: FrameworkComponent: UiIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
This issue is automatically created based on existing pull request: #35101: reference directive restored for _extends.less. extends replaced to mixins in _extend.less
Description (*)
When I installed a clear M2, I saw that the reference
directive removed for the import of _extends.less file. I've found this PR and I explained why removing reference
is a bad idea:
#31793 (comment)
I've investigated later how to restore reference
but repair the issue of Grunt in the PR.
And I've found a solution described here:
#31793 (comment)
@ihor-sviziev asked me to create a PR with the fix, so I made it.
Related Pull Requests
Manual testing scenarios (*)
- Create a new theme which extends Magento Blank theme.
- Compile styles via default deploying (setup:static-content:deploy) and via Grunt.
- Look at block titles of My Account (they should look the same after all build processes).
- Find matches of
abs
selectors instyles-m.css
andstyles-l.css
files. Quantity of them and the size ofstyles-m.css
should be less in comparison with the main branch (2.4-develop).
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: UiIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Type
Projects
Status
Done