Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate code normalizePath method #3844

Closed
davidverholen opened this issue Mar 20, 2016 · 3 comments
Closed

duplicate code normalizePath method #3844

davidverholen opened this issue Mar 20, 2016 · 3 comments
Assignees

Comments

@davidverholen
Copy link
Member

this is more of a minor design issue. I recently needed a method to normalize a file system path.

Looking at the core, I found the method(s) for this, but implemented directly in the classes where they are used:

public static function normalizePath($path)

public static function normalizePath($path)

As I did not really need any of the classes, I implemented this method (a third time) in my own class.

A good place would be maybe the Frameworks File System Class: https://github.com/magento/magento2/blob/2d82d19010a2deee42ab67e62627b84169f0ab8a/lib/internal/Magento/Framework/Filesystem.php

What do you think about it? I could start a small pull request for that

@piotrekkaminski
Copy link
Contributor

@antonkril can you check it?

@antonkril
Copy link
Contributor

Makes sense.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-engcom-team pushed a commit that referenced this issue Mar 11, 2019
GraphQL-433: Prepare Quote GraphQL scheme for 2.3.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants