We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this is more of a minor design issue. I recently needed a method to normalize a file system path.
Looking at the core, I found the method(s) for this, but implemented directly in the classes where they are used:
magento2/lib/internal/Magento/Framework/View/FileSystem.php
Line 169 in 2d82d19
magento2/lib/internal/Magento/Framework/Setup/SampleData/FixtureManager.php
Line 62 in 2d82d19
As I did not really need any of the classes, I implemented this method (a third time) in my own class.
A good place would be maybe the Frameworks File System Class: https://github.com/magento/magento2/blob/2d82d19010a2deee42ab67e62627b84169f0ab8a/lib/internal/Magento/Framework/Filesystem.php
What do you think about it? I could start a small pull request for that
The text was updated successfully, but these errors were encountered:
@antonkril can you check it?
Sorry, something went wrong.
Makes sense.
Thank you for your submission.
We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.
Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).
We are closing this GitHub ticket and have moved your request to the new forum.
Merge pull request #3844 from magento-engcom/ENGCOM-4431
74962be
GraphQL-433: Prepare Quote GraphQL scheme for 2.3.1 release
antonkril
No branches or pull requests
this is more of a minor design issue. I recently needed a method to normalize a file system path.
Looking at the core, I found the method(s) for this, but implemented directly in the classes where they are used:
magento2/lib/internal/Magento/Framework/View/FileSystem.php
Line 169 in 2d82d19
magento2/lib/internal/Magento/Framework/Setup/SampleData/FixtureManager.php
Line 62 in 2d82d19
As I did not really need any of the classes, I implemented this method (a third time) in my own class.
A good place would be maybe the Frameworks File System Class: https://github.com/magento/magento2/blob/2d82d19010a2deee42ab67e62627b84169f0ab8a/lib/internal/Magento/Framework/Filesystem.php
What do you think about it? I could start a small pull request for that
The text was updated successfully, but these errors were encountered: