Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total qty #3853

Closed
valentinazhuk opened this issue Mar 21, 2016 · 4 comments
Closed

Total qty #3853

valentinazhuk opened this issue Mar 21, 2016 · 4 comments
Assignees
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@valentinazhuk
Copy link

class Magento\Quote\Model\Quote\TotalsCollector

In the end function collectAddressTotals

 foreach ($this->collectorList->getCollectors($quote->getStoreId()) as $collector) {
            $collector->collect($quote, $shippingAssignment, $total);
  }
.....

$address->addData($total->getData());

Before line
$address->addData($total->getData())
$address->getTotalQty() return qty but after this return 0

It seems problem here

class Magento\Quote\Model\Quote\Address\Total\Subtotal

function collect

parent::collect($quote, $shippingAssignment, $total);

$total->setTotalQty(0);

$baseVirtualAmount = $virtualAmount = 0;

 $address = $shippingAssignment->getShipping()->getAddress();

I think $total need to change $address:

$baseVirtualAmount = $virtualAmount = 0;

$address = $shippingAssignment->getShipping()->getAddress();
$address->setTotalQty(0);
@ishakhsuvarov
Copy link
Contributor

@valentinazhuk Thank you for reporting this issue. We have created an internal ticket MAGETWO-51545 to investigate and fix the problem.

@ishakhsuvarov ishakhsuvarov added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Apr 5, 2016
@piotrekkaminski
Copy link
Contributor

The issue is currently in QA and should be delivered shortly.

okorshenko pushed a commit that referenced this issue Jul 6, 2016
…n Totals Collector #3853

removed unused value setting
okorshenko pushed a commit that referenced this issue Jul 6, 2016
okorshenko pushed a commit that referenced this issue Jul 6, 2016
…n Totals Collector #3853

added value resetting
fixed unit test
@vkorotun vkorotun removed the CS label Aug 4, 2016
@veloraven
Copy link
Contributor

This issue has been already fixed.
Closed.

@korostii
Copy link
Contributor

Hi @veloraven,
The commits referencing this issue seem to be present on the develop branch only.
Can you please point out the version in which this fix was released?

magento-engcom-team pushed a commit that referenced this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants