Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Static content deploy - Type error #38682

Closed
1 of 5 tasks
Nuranto opened this issue Apr 30, 2024 · 11 comments · Fixed by #38683
Closed
1 of 5 tasks

[Issue] Static content deploy - Type error #38682

Nuranto opened this issue Apr 30, 2024 · 11 comments · Fixed by #38683
Assignees
Labels
Area: Framework Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Nuranto
Copy link
Contributor

Nuranto commented Apr 30, 2024

Preconditions and environment

  • Magento version 2.4.7

Steps to reproduce

  1. Create an empty less file in your theme
  2. Launch setup:static-content:deploy --force

Expected result

The error "LESS file is empty" is displayed correctly

Actual result

 Magento\Framework\Exception\LocalizedException::__construct(): Argument #1 ($phrase) must be of type Magento\Framework\Phrase, string given, called in /var/www/html/vendor/magento/module-deploy/Service/DeployPackage.php on line 142

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 30, 2024

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Apr 30, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Apr 30, 2024
@engcom-Delta
Copy link
Contributor

Hi @Nuranto ,

Thanks for reporting and collaboration.

Verified the issue in Magento 2.4 dev instance and 2.4.7 and the issue is not reproducible.

Steps to reproduce:

1.Create an empty less file in your theme
2.Launch setup:static-content:deploy --force

Please refer the attached screenshots, data and let us know if we missed anything.

Created an empty less file in luma theme abc.less

Screenshot 2024-05-02 at 8 03 43 PM

bin/magento setup:static-content:deploy --force , it's ran successfully

Screenshot 2024-05-02 at 8 04 46 PM

@engcom-Delta engcom-Delta added the Issue: needs update Additional information is require, waiting for response label May 2, 2024
@Nuranto
Copy link
Contributor Author

Nuranto commented May 2, 2024

Rename _abc.less to abc.less, and you should be able to reproduce the issue. (The goal here is just to generate an error during compilation. You can use another method for that if you want. The issue is about an error that happens when an error is displayed)

@engcom-Delta
Copy link
Contributor

Hi @Nuranto,

Verified the issue on 2.4-develop, 2.4.7 and it is reproducible.

Hence, Confirming the issue.

Steps to reproduce:-

1.Create an empty less file in your theme
2.Launch setup:static-content:deploy --force

Screenshot 2024-05-02 at 9 53 54 PM Screenshot 2024-05-02 at 10 08 20 PM

Please refer the attached screenshot.

@engcom-Delta engcom-Delta added Component: Exception Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 3, 2024
@engcom-Delta engcom-Delta removed the Issue: needs update Additional information is require, waiting for response label May 3, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11905 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented May 3, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mrtuvn
Copy link
Contributor

mrtuvn commented May 7, 2024

seem you need use file less with underscore for solve problem. Magento not allow you import styles without underscore
I'm not sure but seem problem related with php version and lessphp compiler package may not fully compatible with new php
Magento used this one "wikimedia/less.php" for gen styles by php

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label May 7, 2024
@Kishorchhugani
Copy link

my less file not empty still giving me same error after upgrading to 2.4.7 in deploy command !!!

any Updates ?

@pyyick
Copy link

pyyick commented May 30, 2024

I also face this issue too. I filled something in that empty css file as a workaround.

@gntlby
Copy link

gntlby commented Jun 21, 2024

I have the same problem, is there any update?

`Compilation from source: /home/XXX/public_html/vendor/magento/theme-frontend-blank/web/css/styles-m.less
Named argument for .transition @transition not found in _module.less

Error happened during deploy process: Magento\Framework\Exception\LocalizedException::__construct(): Argument #1 ($phrase) must be of type Magento\Framework\Phrase, string given, called in /home/cepmania/public_html/vendor/magento/module-deploy/Service/DeployPackage.php on line 142`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

8 participants