Undefined array key in ProductRepository getById

[galdiuz]

Preconditions and environment

Tested on Magento 2.4.8-p1.

getById() function in Magento\Catalog\Model\ProductRepository produces an "Undefined array key" if the $productId argument is a string that starts with a valid product ID but contains other trailing characters. For example if you have a product with ID 123 and the function is called with $productId value of "123abc".

Steps to reproduce

1. Have the ID of a product (123 in this example).
2. Navigate to the product page but append characters to the ID like /catalog/product/view/id/123abc

Expected result

A 404 not found page.

Actual result

An exception is thrown.

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @galdiuz. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @galdiuz,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

We are getting 404 not found page.Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[galdiuz]

There needs to exist a product with the used ID for the exception to happen. If product with entity ID 123 does not exist then you get a 404 as expected. Create a product and use its ID to reproduce.

[galdiuz]

Technically the reason that this happens is because because the string is implicitly converted to an int when passed to $product->load($productId), meaning "123abc" is converted to 123 per PHP's rules for numeric strings. This means the product is successfully loaded but then cached with the proper ID in $this->instancesById, producing the error on this line when attempting to access with $productId variable.

For the same reason /catalog/product/view/id/123.0 or /catalog/product/view/id/1.23e2 will produce the same error, as both these will be converted to the int 123.

[engcom-Bravo]

Hi @galdiuz,

Thanks for your Update.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Exception was thrown in exception.log

#90 {main} {"exception":"[object] (Exception(code: 0): Warning: Undefined array key \"123abc\" in /usr/local/var/www/magentop/magento2/app/code/Magento/Catalog/Model/ProductRepository.php on line 327 at /usr/local/var/www/magentop/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:61)"} []

Hence Confirming the issue.

Thanks.