Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$orderIncrementId may not be int #402

Closed
dbsdsun opened this issue Nov 6, 2013 · 2 comments
Closed

$orderIncrementId may not be int #402

dbsdsun opened this issue Nov 6, 2013 · 2 comments

Comments

@dbsdsun
Copy link

dbsdsun commented Nov 6, 2013

Problem:

In Magento 2 database, table sales_flat_order, field increment_id is varchar.
But in Magento\Sales\Model\Resource\Quote, function isOrderIncrementIdUsed,
$orderIncrementId is type casted to int. That does match the database definition.

          $bind      = array(':increment_id' => (int)$orderIncrementId);

In our Magento 1.6, one increment_id is '10-O-00005002', type-casting '10-O-00005002' to int caused subsquential problems.

Solution:

change the code

    $bind      = array(':increment_id' => (int)$orderIncrementId);

to

    $bind      = array(':increment_id' => $orderIncrementId);
@philwinkle
Copy link
Contributor

Duplicate of #390

@verklov
Copy link
Contributor

verklov commented Dec 23, 2013

dbsdsun,
Thank you for reporting this issue! As philwinkle already noticed, your issue is a duplicate of issue #390 describing pull request #406. The code in the contribution has been released with the most recent code update dev57. Please check dev57 for the solution.

@verklov verklov closed this as completed Dec 23, 2013
magento-team pushed a commit that referenced this issue Jul 3, 2015
…il-Template-PR

[API] Responsive Email Template - Merging outsourced PR 5
magento-team pushed a commit that referenced this issue Mar 12, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Frontend Bugs - 2.0.11
- MAGETWO-57509 [Backport] - [GitHub] Javascript Bundling produces huge 13MB js files #4506 - for 2.0
- MAGETWO-56076 [Backport] Versioning of static files (CSS, JS, Fonts, Images, etc.) doesn't enabled by default - for 2.0
magento-devops-reposync-svc pushed a commit that referenced this issue May 24, 2022
…te-email

CABPI-199: Send email to newly created admin user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants