-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Folder Location / Update Package #4025
Comments
Hi @adamzero1 we have published magento/updater project (current version is 10.0.0). This project preinstalled in "/update" folder because we would like to make installation easy and avoid one more step in installation process (installation of updater). BTW, you do not need to recreate Magento project, you can just delete update folder and run "composer create-project magento/updater --repository-url=https://repo.magento.com/ update" to have new version of Updater. Thank you. |
Hi @vancoz, Thank you for your response, I feel I may not have explained why I felt this was an issue correctly, however as the package is already available on repo.magento.com I think this will solve the issue I am having. So thank you for that, much appreciated. I am curious as to how I can't find any documentation about this package anywhere, along with the fact that the list of packages on repo.magento.com isn't accessible, easily? The final snag I am now having is that So I cannot require both in my project: Problem 1 Many thanks |
Hi @adamzero1, you are right updater and Magento 2.0.x requires different composer version. We are working on docs about it. Thank you. |
Hi @vancoz, It seemed to make sense to me that I would be able to create a project that required a certain versions of both (along with any other packages I desire), making it easier for me to manage exactly what is in my project? "require": { Many thanks |
Hi @adamzero1 thank you for your intention to help, we really proud of our community and really appreciate it. Let me explain to you background: Updater can not be Magento requirement - because this is tool which runs "composer update" to update Magento code (base package, modules etc...). So Updater it will be part of Magento requirement - during "System Upgrade" Updater will try to delete old version of itself and install new. This is not acceptable, component can not upgrade itself. Updater is kind of Magento firmware, main responsibility of Updater is manage(install/update/uninstall) Magento components. You have background of this decision now, so fell free to offer some better solution, we will appreciate it. Thank you. |
Hi @vancoz , I do however appreciate that you are trying to create a solution that allow user to manage everything through a web GUI which can be challenging. To me I can see two desired functions:
The only way to avoid having an entity that updates itself would be to move the function of "updating the updater" out of the updater. If this was done, then there would be no reason that the updater could be a require-able package. I know this seems tedious, but I am trying to look at this from managing multiple clients. I want to be able to provide a solution where a client can install modules themselves from magento connect (requiring the updater), but in the same breath I want all information on what packages and version a client contains in one location. I hope that makes sense? Many thanks |
Hi @adamzero1 if we will have Updater as part of Magento requirements, that means that autoload files, vendor directory etc will be shared. So we would not be able to manage Magento dependencies and keep Updater safe from failure, that's why we need to keep Updater as separate project. Regarding managing multiple instances - completely agree with you, I'm sure that we need to make easy procedure how to upgrade Updater (ideally it should be part of flow in Setup Wizard and right now we are looking for way how to implement it - for example Setup Wizard (which is part of Magento) can be responsible for it, so Updater will not try to update itself). What about "Updater" in Marketplace (connect), I do not think that this project will be shipped as extension in connect. Currently Marketplace supports "magento-*" and "metapackage" package types, and Marketplace packages should be part of Magento (requirement) when Updater is independent tool. Thank you. |
@adamzero1 do you feel that explanation is helpful and we can close the issue? |
Hi @vancoz, Apologies on the late response. Thanks again. |
Hi @adamzero1, thank you. Anyway if you have more question or proposals - fell free to discuss. |
[EngCom] Public Pull Requests - GraphQL
Hi,
I'm not sure if this is the correct place to raise this as an issue, however I wanted to get the ball rolling.
Can the "/update" folder in the repo: https://github.com/magento/magento2-community-edition be moved into an external package e.g: magento2-update". This will allow people to get the updates without having to merge that repo back in to whatever they have.
If this is not the correct location to raise this issue, please can you point me in the right direction?
Many thanks
Adam
The text was updated successfully, but these errors were encountered: