Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore config setting #404

Closed
tzyganu opened this issue Nov 7, 2013 · 15 comments
Closed

Restore config setting #404

tzyganu opened this issue Nov 7, 2013 · 15 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Nov 7, 2013

A "Restore to default" button or checkbox would be useful for the fields in System->Configuration that would just delete the value in the table core_config_data thus making Magento use the value declared in config.xml, or an empty value if that does not exist.
If not all fields should be allowed to be "restored to default" maybe this can be managed from system.xml with a new attribute on the <field> tag. Example

<field id="list_mode" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="0"><!-- or canRestore="1" --> <label>List Mode</label> <source_model>Magento\Catalog\Model\Config\Source\ListMode</source_model> </field>

@airbone42
Copy link

+1 great idea

@guillaumedeneux
Copy link

+1

@barbazul
Copy link
Contributor

+1

I would be very useful and fairly easy to implement
El 26/08/2014 12:50, "Guillaume Deneux" notifications@github.com escribió:

+1


Reply to this email directly or view it on GitHub
#404 (comment).

@ihor-sviziev
Copy link
Contributor

+1

1 similar comment
@igrslv
Copy link

igrslv commented Aug 27, 2014

+1

@tzyganu
Copy link
Contributor Author

tzyganu commented Aug 28, 2014

I just wanted to add more details on how I would see this implemented.
So the "Restore to default" checkbox should appear only on the Default config screen.
If the user checks the checkbox, only the value for the selected path with the scope 'default' will be deleted.
If the user wants to reset a value at store view or website level, he can do it like it is done now.
Change the scope to store view and check the checkbox Use Website.
Change the scope to website and check the checkbox Use Default.

In my opinion all the cases should be covered by this approach.

@MagentoFarsi
Copy link

+1

2 similar comments
@rakshazi
Copy link

+1

@RahulKachhadia
Copy link
Member

+1

@Tiurnikova
Copy link

Hello @tzyganu ,
Thank you for the interesting suggestion.
3rd party modules also use core_config_data table to save their settings.
Adding this feature means to impose the condition that these modules should support drop settings option too. What are thoughts on that?

@tzyganu
Copy link
Contributor Author

tzyganu commented Sep 1, 2014

@Tiurnikova
I see no problem about this.
If the third party modules have the attribute canRestore="0" (see my initial statement) for a specific config setting it should work the same.
I realize now that maybe I didn't explain my idea correctly.
this "restore to default" checkbox should be specific for each config setting.
Just like you have a checkbox right now with "Use default value" when editing the config on a website scope.
From what I found, if you edit the config on a website level and you check the "Use default value" checkbox, the value stored in the core_config_data for that specific setting for the specific website is deleted. Am I right?
My idea was to have the "Restore to default " checkbox on the "Default config" scope for each config setting that supports it. If that is checked and I hit "Save", the value for the default config will also be deleted from the table core_config_data letting magento use the value declared in the config.xml.

Just to make it clear... I wasn't reffering to a "Restore to factory settings" feature that would delete everything in the core_config_data. That would be dangerous indeed.
Just one "restore" for every setting (field) that appears in System->Configuration.

Let me know if this time I made it clear.

@Tiurnikova
Copy link

@tzyganu, yes. Now it's clear. Thank you for clarification.
You mean - ability to restore settings to default for each field separately. Got it.
That definitely makes sense.

@maksek maksek added the PROD label Jan 8, 2015
@ilol ilol added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 2, 2015
@ilol
Copy link

ilol commented Mar 2, 2015

MAGETWO-34400

magento-team pushed a commit that referenced this issue Jul 3, 2015
[Folks] Checkout bug-fixes and improvements
@tzyganu
Copy link
Contributor Author

tzyganu commented May 9, 2016

Since the PR was merged, I will close this issue.
So after the 2.5 years that have passed since this issue was opened, I can finally make the stupid joke. Issue #404..."Issue not found".

@shivkumarsingh7
Copy link

Very helpful information

magento-engcom-team added a commit that referenced this issue Apr 5, 2019
 - Merge Pull Request magento/graphql-ce#404 from magento/graphql-ce:295-place-order
 - Merged commits:
   1. 43e684f
   2. 65dbb0c
   3. 000f2a2
   4. c80e1ba
   5. d86345b
   6. 6c7b1db
   7. 452f6b0
   8. 61b4ec8
   9. 2299cf9
   10. d0c9cfa
magento-devops-reposync-svc pushed a commit that referenced this issue May 24, 2022
…th-using-ims-access-token

CABPI-224 web api auth using ims access token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests