Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echo vs print #418

Closed
ihor-sviziev opened this issue Nov 21, 2013 · 4 comments
Closed

Echo vs print #418

ihor-sviziev opened this issue Nov 21, 2013 · 4 comments

Comments

@ihor-sviziev
Copy link
Contributor

Hi,
In some places you use keyword "print", in other - "echo". I think we should use only one of them.
@Flyingmana
Copy link
Member

I dont see a problem here, as it is only used in a few old places as far as I see.

Is there a special place where the use of print annoys you?

@ihor-sviziev
Copy link
Contributor Author

Flyingmana,
https://github.com/magento/magento2/blob/master/lib/Magento/App/Http.php#L127
https://github.com/magento/magento2/blob/master/lib/Magento/Error/Handler.php#L63
https://github.com/magento/magento2/blob/master/app/code/Magento/Downloadable/Helper/Download.php#L340
and few another cases, as example.

magento-team added a commit that referenced this issue Mar 7, 2014
@magento-team
2.0.0.0-dev68
c6856aa 
* Cache:
  * Implemented depersonalization of private content generation
  * Implemented content invalidation
  * Added Edge Side Includes (ESI) support
  * Added a built-in caching application
* GitHub requests:
  * [#454](#454) -- Allow to specify list of IPs in a body on maintenance.flag which will be granted access even if the flag is on
  * [#204](#204) -- Mage_ImportExport: Exporting configurable products ignores multiple configurable options
  * [#418](#418) -- Echo vs print
  * [#419](#419) -- Some translation keys are not correct.
  * [#244](#244) -- Retrieve base host URL without path in error processor
  * [#411](#411) -- Missed column 'payment_method' of table 'sales_flat_quote_address'
  * [#284](#284) -- Fix for Issue #278 (Import -> Stores with large amount of Configurable Products)
* Fixed bugs:
  * Fixed an issue where Mage_Eav_Model_Entity_Type::fetchNewIncrementId() did not rollback on exception
  * Fixed an issue where a category containing more than 1000 products could not be saved
  * Fixed inappropriate error messages displayed during installation when required extensions were not installed
  * Fixed synopsis of the install.php script
  * Fixed an issue where the schedule of recurring payments was not displayed in the shopping cart
* Modularity improvements:
  * Introduced the OfflinePayments module - a saparate module for offline payment methods
  * Added the ability to enable/disable the Paypal module
  * Moved the framework part of the Locale functionality from the Core module to library
  * The Locale logic was split among appropriate classes in library, according to their responsibilities
  * Removed the deprecated DHL functionality
  * Introduced the OfflineShipping module for offline shipping carrier functionality: Flatrate, Tablerate, Freeshipping, Pickup
  * Introduced a separate module for the DHL shipping carrier
  * Introduced a separate module for the Fedex shipping carrier
  * Introduced a separate module for the UPS shipping carrier
  * Introduced a separate module for the USPS shipping carrier
* Framework Improvements:
  * Added the ability to intercept internal public calls
  * Added the ability to access public interface of the intercepted object
  * Added a static integrity test for plugin interface validation
  * Added support for both class addressing approaches in DI: with and without slash ("\") at the beginning of a class name
* Customer Service usage:
  * Refactored the Customer module blocks and controllers to use customer service layer
* Security:
  * Introduced the ability to hash a password with a random salt of default length (32 chars) by the encryption library
  * Utilized a random salt of default length for admin users, and frontend customers
@ihor-sviziev
Copy link
Contributor Author

Great, thanks!

@verklov
Copy link
Contributor

verklov commented Mar 8, 2014

@igor-svizev, the team has fixed this issue. All existing usages of print were replaced by echo. The code has been released in dev68.

magento-team pushed a commit that referenced this issue Jul 15, 2015
Merge pull request #418 from magento-folks/checkout
e1b0bb8 
[Folks] Enhanced Checkout Flow. Part III
magento-team pushed a commit that referenced this issue Mar 10, 2016
Merge pull request #418 from magento-vanilla/MAGETWO-41205-PR
197a6df 
[Vanilla+WebDev] Staging: Dashboard
mmansoor-magento pushed a commit that referenced this issue Sep 28, 2016
@kandy
Merge pull request #418 from magento-mpi/MPI-PR-bugfixes
0a6c5b2 
[MPI] Bugfixes
magento-devops-reposync-svc pushed a commit that referenced this issue May 24, 2022
@slopukhov
Merge pull request #418 from magento-performance/cabpi-329-fix-redund…
458f0e4 
…ant-dependency

CABPI-329: Fix redundant dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Flyingmana @ihor-sviziev @verklov