Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to Cart" Button translation partly broken #4181

Closed
thomvanderboon opened this issue Apr 17, 2016 · 4 comments
Closed

"Add to Cart" Button translation partly broken #4181

thomvanderboon opened this issue Apr 17, 2016 · 4 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@thomvanderboon
Copy link

This is follow up to closed issue: #2056

One issue still remains:"Add to Cart" Button translation is partly broken

Steps to reproduce

  1. Install Magento from develop branch.
  2. cd <document_root>/var
  3. get latest translationfile: wget http://107.170.242.99/var/Head/source_nl_NL.csv
  4. cd ..
  5. find . -name js-translation.json -exec rm -rf {} ;
  6. php bin/magento i18n:pack --mode=replace -d var/source_nl_NL.csv nl_NL
  7. php bin/magento setup:static-content:deploy en_US nl_NL
  8. php bin/magento indexer:reindex
  9. php bin/magento cache:clean
  10. php bin/magento cache:flush
  11. Change locale to nl_NL
  12. Add a simple product
  13. Surf to website: Go to category list or wish list, click "add to cart". The button nicely changes to the translated strings "Adding...", "Added", "Add to Cart"
  14. Go to the product page: Click the translated "Add to Cart" button

Expected result

  1. Show translated strings of "Adding...", "Added", and "Add to Cart"

Actual result

  1. "Adding...", "Added", and "Add to Cart" are not translated
@vrann vrann added the PS label Apr 17, 2016
@mazhalai
Copy link
Contributor

@thomvanderboon thank you for reporting, we have MAGETWO-51987 to investigate and fix.

@mazhalai mazhalai added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 18, 2016
magento-team pushed a commit that referenced this issue May 3, 2016
…#4181

- Was getting loaded too early. Before translation file gets populated. Added mechanism to prevent that.
magento-team pushed a commit that referenced this issue May 3, 2016
@okorshenko
Copy link
Contributor

@thomvanderboon Thank you for reporting the issue. Fix for MAGETWO-51987 merged to develop branch.

@thomvanderboon
Copy link
Author

thomvanderboon commented May 4, 2016

@okorshenko Thanks. Did test on latest development and I can confirm issue is fixed. Please move the i18n fixes a.s.a.p. to the stable branch Please :)

@nmallepally
Copy link

Hello Thanks for the updates, but the error messages on website and some check out steps like shipping and review payments are still in English does not translate. attaching images for reference
checkout english
password not good enought
remove_from_cart

magento-engcom-team pushed a commit that referenced this issue May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants