Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please combine tier pricing messages into block sentences... #424

Closed
hidonet opened this issue Nov 29, 2013 · 6 comments
Closed

Please combine tier pricing messages into block sentences... #424

hidonet opened this issue Nov 29, 2013 · 6 comments
Assignees
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@hidonet
Copy link

hidonet commented Nov 29, 2013

Please combine tier pricing messages into block sentences...

@elenleonova
Copy link

Hi hidonet,
Would you mind to provide more information regarding your request, so we will be sure that we are on the same page with the suggested improvement?
Thanks

@hidonet
Copy link
Author

hidonet commented Dec 3, 2013

Hi,
  Sentences about tier pricing in
  /app/design/frontend/base/default/template/catalog/product/view/tierprices.phtml
  is sliced to some parts. This makes translation difficult in some
  languages ( e.g. Turkish ).
  Example : line 105 "Buy %1$s for %2$s each"
  and line 189 <?php echo
  $this->__('save')?>&nbsp;<span class="percent
  tier-<?php echo $_index;?>"><?php echo
  $_price['savePercent']?></span>%
  Your Combined sentence is : Buy %1$s for %2$s each save 10%
  If you combine this into one sentence I can change order of
  variables. 
  Example : 
  "%1$ adet al, %2$ öde, %3$ karlı çık" 
  or 
  "Tanesine %2$ ödeyip, %1$ adet al, %3$ indirimli al"

@vpelipenko
Copy link
Contributor

@hidonet, sorry for so late response, but I hope it will still useful for all. If we look at app\code\Magento\Catalog\view\base\templates\product\price\tier_prices.phtml we can see that phrase 'Buy %1 for %2 each and save %3' consists of 4 smaller phrases: 'Buy %1 for %2', 'each', 'and', 'save'.

First 2 can be easy combined, but the last two are the part of template, contain HTML formatting and depend on settings. It means that the last part of phrase 'and save %3' will appear on frontend if we enable showing detailed prices in backend settings. Does it make sense for you if we combine only first two phrases and leave the rest as is?

@hidonet
Copy link
Author

hidonet commented Jan 27, 2015

I know this file and sentences. But in some languages ( for example in Turkish ) meaningfully combining sliced sentences is very difficult. Please add single sentence for every single state.

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed PROD labels Jan 29, 2015
@vpelipenko
Copy link
Contributor

Internal ticket has been created: MAGETWO-33393. We'll investigate the issue and come back with our solution.

@kokoc
Copy link
Member

kokoc commented Jun 2, 2015

@hidonet Thank you for reporting the issue. The team has processed this ticket. Code changes have just been deployed in version 0.74.0-beta11. Could you please verify the issue?

vpelipenko added a commit that referenced this issue Jul 15, 2015
[MPI]  Accepting and Rejecting Transactions Marked as "Held for Review" by Gateway
mmansoor-magento pushed a commit that referenced this issue Sep 26, 2016
Fixed issues:
- MAGETWO-58265: Fix Varnish X-Header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests

7 participants