-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please combine tier pricing messages into block sentences... #424
Comments
Hi hidonet, |
|
@hidonet, sorry for so late response, but I hope it will still useful for all. If we look at app\code\Magento\Catalog\view\base\templates\product\price\tier_prices.phtml we can see that phrase 'Buy %1 for %2 each and save %3' consists of 4 smaller phrases: 'Buy %1 for %2', 'each', 'and', 'save'. First 2 can be easy combined, but the last two are the part of template, contain HTML formatting and depend on settings. It means that the last part of phrase 'and save %3' will appear on frontend if we enable showing detailed prices in backend settings. Does it make sense for you if we combine only first two phrases and leave the rest as is? |
I know this file and sentences. But in some languages ( for example in Turkish ) meaningfully combining sliced sentences is very difficult. Please add single sentence for every single state. |
Internal ticket has been created: MAGETWO-33393. We'll investigate the issue and come back with our solution. |
@hidonet Thank you for reporting the issue. The team has processed this ticket. Code changes have just been deployed in version 0.74.0-beta11. Could you please verify the issue? |
[MPI] Accepting and Rejecting Transactions Marked as "Held for Review" by Gateway
Fixed issues: - MAGETWO-58265: Fix Varnish X-Header
Please combine tier pricing messages into block sentences...
The text was updated successfully, but these errors were encountered: