Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.4 Credit memos with adjustment fees cannot be fully refunded with a second credit memo #4272

Closed
snez opened this issue Apr 22, 2016 · 6 comments
Assignees
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@snez
Copy link

snez commented Apr 22, 2016

Steps to reproduce

  1. With USD as the base currency, create a second store with a GBP store view currency
  2. Set the GBP currency rate of that store to 0.6
  3. Place an order in the GBP store
  4. Issue a credit memo from the admin area, setting an Adjustment Fee of $1
  5. Try to create a second credit memo to refund the remaining $1 and completely close the order
    Example adjustment fee

Expected result

The second credit memo should allow us to refund the remaining $1

Actual result

The credit memo has a total due amount of $0 and cannot fully refund the order
Example of the issue

@snez
Copy link
Author

snez commented Apr 22, 2016

As a side note to this, when the credit memo is accessed from the payment method in the called cancel() method, it seems to be missing some key data, see store_to_base_rate and store_to_order_rate below:

[creditmemo (Magento\Sales\Model\Order\Creditmemo)] => Array
    (
        [order_id] => 37
        [store_id] => 2
        [customer_id] => 2
        [billing_address_id] => 74
        [shipping_address_id] => 73
        [global_currency_code] => USD
        [base_currency_code] => USD
        [store_currency_code] => USD
        [order_currency_code] => GBP
        [store_to_base_rate] => 0.0000
        [store_to_order_rate] => 0.0000
        [base_to_global_rate] => 1.0000
        [base_to_order_rate] => 0.6000

@piotrekkaminski
Copy link
Contributor

Internal issue MAGETWO-53264

@palamar palamar added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 22, 2016
@vkorotun vkorotun removed the CS label Aug 4, 2016
@vherasymenko
Copy link

Steps to reproduce:

  1. Install Magento latest develop version
  2. Go to Admin side
  3. Click "Stores > All Stores"
  4. Click "Add new store view"
  5. Enter name and code, set status "Enabled" and click "Save"
  6. Click "Stores > Configuration"
  7. In header side choose created Store View
  8. Click "General > Currency Setup"
  9. "Default Display Currency" set "British Pound Sterling"
  10. "Allowed Currencies" set "British Pound Sterling" then click "Save"
  11. Click "Stores > Currency rates"
  12. In row GPB enter 0.6 and click "Save"
  13. Place order on "GB" store view"
  14. Go to Admin side "Sales > Orders"
  15. Receive Invoice and after that click "Credit Memo"
  16. Scroll page down and enter in field "Adjustment Fee" 1$ then click "Refund"
  17. Click "Credit Memo" again and scroll page down
  18. Pay attention on "Subtotal" in Refund Totals table.

AR: Displayed 0$
ER: Should be displayed $1

@mcspronko
Copy link
Contributor

@ishakhsuvarov @maksek Can you please assign this one on me? I will work on it. Thanks.

magento-team pushed a commit that referenced this issue May 27, 2017
… be fully refunded with a second credit memo #9715

 - Merge Pull Request #9715 from mcspronko/magento2:creditmemo-fix
magento-team pushed a commit that referenced this issue May 27, 2017
… be fully refunded with a second credit memo #9715
magento-team pushed a commit that referenced this issue May 27, 2017
[EngCom] Public Pull Requests
 - MAGETWO-69379 use payment method name to make checkbox of agreements more unique #6207 #9717
 - MAGETWO-69378 #4272: v2.0.4 Credit memos with adjustment fees cannot be fully refunded with a second credit memo #9715
 - MAGETWO-69375 Can't delete last item in cart if Minimum Order is Enable #6151 #9714
 - MAGETWO-69230 #7279 bill-to name and ship-to name truncated to 20 chars #9654
 - MAGETWO-69155 Fix coding standard in Magento AdminNotification module #9627
@ishakhsuvarov
Copy link
Contributor

Closing, as issue is fixed in the develop branch with the linked PR and commits.

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69378

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue Jun 4, 2019
…5806

[Owls] MAGETWO-55806: Eliminate @escapeNotVerified in Tax-related Modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests