consistency in Magento\Tax\Helper\Data

[fooman]

Currently neither the method naming nor the content is consistent.

For example

public function discountTax($store=null)
{
    return $this->_config->discountTax($store);
}

vs

public function getTaxBasedOn($store = null)
{
    return $this->_coreStoreConfig->getConfig(\Magento\Tax\Model\Config::CONFIG_XML_PATH_BASED_ON, $store);
}

[verklov]

fooman,
Thank you for noting this issue! We will consider making the appropriate changes to the names of already existing methods, but unfortunately this is not in our roadmap for the nearest releases.

[fooman]

While I fully understand this is not on the immediate roadmap why close the issue? My hope is that pointing out inconsistencies like the above will make it easier for developers to learn Magento (which I thought was a goal of Magento 2). Also fixing inconsistencies before the 2.0 release would be preferred since later on you would need to worry about backwards compatibility which would not help in the ease of understanding the code.

[benmarks]

I must concur with @fooman. Consistency in method names - at the very least among getters and setters - is a subtle but important means for reducing mental burden among the developers who will be working with M2.