Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect return value from Product Attribute Repository #4803

Closed
samtay opened this issue May 31, 2016 · 8 comments
Closed

Incorrect return value from Product Attribute Repository #4803

samtay opened this issue May 31, 2016 · 8 comments
Assignees
@julian-van-drielen
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@samtay
Copy link

samtay commented May 31, 2016

To adhere to Magento\Catalog\Api\ProductAttributeRepositoryInterface (extends Magento\Framework\Api\MetadataServiceInterface), the

Magento\Catalog\Model\Product\Attribute\Repository::getCustomAttributesMetadata

implementation should return Magento\Framework\Api\MetadataObjectInterface[], however it instead returns Magento\Catalog\Api\Data\ProductAttributeInterface[].

The ProductAttributeInterface does declare the two methods declared in MetadataObjectInterface , however they are not related by PHP extend.
@andimov
Copy link
Contributor

andimov commented Jun 23, 2016

@samtay, to allow us research the issue, please, provide the used version and description according to the template.

@andimov andimov self-assigned this Jun 23, 2016
@samtay
Copy link
Author

samtay commented Jun 24, 2016

The issue exists on all versions, on CE develop branch. The description is in the initial comment. I don't see what more information you need? This isn't a huge deal, I'm just letting you know there is a disconnect in the hierarchy of the interfaces. The documentation is incorrect -- which the framework can be very finicky about sometimes when generating code or parsing objects in the webapi. Something for you to be aware of.

@andimov andimov removed their assignment Jun 24, 2016
@vkublytskyi
Copy link

vkublytskyi commented Jul 15, 2016 •
edited
Loading

@samtay, thank you for reporting this issue. To fix this issue we will add declaration that Magento\Eav\Api\Data\AttributeInterface extends Magento\Framework\Api\MetadataObjectInterface.
Internal ticket MAGETWO-55438.

@vkublytskyi vkublytskyi added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report and removed improvement labels Jul 15, 2016
@vkublytskyi vkublytskyi removed their assignment Jul 15, 2016
@vkorotun vkorotun removed the MX label Aug 4, 2016
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed TECH labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 23, 2017
@magento-engcom-team
Copy link
Contributor

@samtay, thank you for your report.
We've created internal ticket(s) MAGETWO-55438 to track progress on the issue.

@julian-van-drielen julian-van-drielen self-assigned this Jun 2, 2018
@julian-van-drielen
Copy link

I will be working on this issue

This was referenced Jun 2, 2018
Merged
Merged
Merged
@okorshenko okorshenko removed the mm18nl label Jun 5, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Aug 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @samtay. Thank you for your report.
The issue has been fixed in #15691 by @cream-julian in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team added a commit that referenced this issue Aug 8, 2018
@magento-engcom-team
ENGCOM-2642: Fix #4803: Incorrect return value from Product Attribute…
e940892 
… Repository #15691

 - Merge Pull Request #15691 from cream-julian/magento2:2.2-develop-forward-issue-4803
 - Merged commits:
   1. 4c1989e
   2. 215be5a
   3. 2639d0e
   4. 43dd85e
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2018
ENGCOM-2642: Fix #4803: Incorrect return value from Product Attribute…
2a67339 
… Repository #15691
@sidolov
Copy link
Contributor

sidolov commented Aug 8, 2018

Hi @samtay. Thank you for your report.
The issue has been fixed in #15688 by @cream-julian in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 8, 2018
magento-engcom-team added a commit that referenced this issue Aug 8, 2018
@magento-engcom-team
ENGCOM-2707: [Backport] Fix #4803: Incorrect return value from Produc…
fd0af2f 
…t Attribute Repository #15688

 - Merge Pull Request #15688 from cream-julian/magento2:2.1-develop-issue-4803
 - Merged commits:
   1. d409248
   2. 90f37dc
   3. b064cd7
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2018
ENGCOM-2707: [Backport] Fix #4803: Incorrect return value from Produc…
8f77ca1 
…t Attribute Repository #15688
@magento-engcom-team
Copy link
Contributor

Hi @samtay. Thank you for your report.
The issue has been fixed in #15723 by @cream-julian in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 10, 2018
magento-engcom-team added a commit that referenced this issue Aug 10, 2018
@magento-engcom-team
ENGCOM-2708: [Forwardport] Fix #4803: Incorrect return value from Pro…
b7c3c3d 
…duct Attribute Repository #15723

 - Merge Pull Request #15723 from cream-julian/magento2:2.3-develop-forward-issue-4803
 - Merged commits:
   1. 19ca090
   2. 4e51e9c
   3. a8dc518
   4. 40f046e
magento-engcom-team pushed a commit that referenced this issue Aug 10, 2018
ENGCOM-2708: [Forwardport] Fix #4803: Incorrect return value from Pro…
f1d027c 
…duct Attribute Repository #15723
magento-engcom-team pushed a commit that referenced this issue Sep 23, 2019
@vzabaznov
Merge pull request #4803 from magento-performance/MC-18719
d6ef3ef 
Customer data invalidation fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julian-van-drielen julian-van-drielen

Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests