Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing admin order view product data for grouped downloadable order items #4815

Closed
wbyrnetx opened this issue Jun 1, 2016 · 2 comments
Closed

Comments

@wbyrnetx
Copy link
Contributor

wbyrnetx commented Jun 1, 2016

Steps to reproduce

  1. Install Magento 2.0.7.
  2. Create a grouped product that has an associated downloadable product.
  3. Place an order for that downloadable product.

Expected result

  1. When viewing the order in the admin panel there will be no data under the "Product" column.
    screen shot 2016-06-01 at 7 40 11 am
@wbyrnetx
Copy link
Contributor Author

wbyrnetx commented Jun 1, 2016

I put in a new pull request with a proposed solution (#4816). I just took the logic from

Magento\Sales\Block\Adminhtml\Items\AbstractItems::getColumnHtml

And put it in in that name group renderer's _toHtml function. The main part that was replaced is

$renderer = $this->getRenderedBlock()->getColumnHtml($this->getItem(), $productType);

Which doesn't make much sense in the first place because getColumnHtml expects a column name as a second argument, not a productType.

wbyrnetx added a commit to wbyrnetx/magento2 that referenced this issue Jun 1, 2016
was not rendering correctly when the real product type was
downloadable (see Issue magento#4815).
@NadiyaS NadiyaS self-assigned this Jun 1, 2016
@NadiyaS NadiyaS assigned kandy and unassigned NadiyaS Jun 6, 2016
@NadiyaS NadiyaS added MX and removed CS labels Jun 6, 2016
@vkorotun vkorotun removed the MX label Aug 4, 2016
@veloraven
Copy link
Contributor

This issue was fixed.
Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants