Dependencies of Magento_Core

[CodeMonkey90]

Magento_Core still depends on Magento_GiftMessage, Magento_GoogleAnalytics and Magento_GoogleCheckout, all of which are modules that some people might want to disable. Will those dependencies be removed before the final release?

[verklov]

@Landkeks , thank you for asking this question!
I assigned this issue to @eleonova , who should be able to respond on your inquiry better.

[elenleonova]

@Landkeks, we don't have those plans yet, however, I would like to hear feedback from the community if those modules are very critical ones to be decoupled.

[CodeMonkey90]

@eleonova: All I can personally say is that none of our customers need or want the functionality of the GiftMessage module and that none of them currently use Google Checkout. GoogleAnalytics is the only module we're actually using.

[ivanweiler]

I agree with the suggestion. Google checkout is rarely used and discontinued by Google if I'm not mistaken, gift message is rarely used, GoogleAnalytics are needed but Core shouldn't depend on them. I would also add Magento_ProductAlert to the list.

[JoseHawkins]

I cannot find dependency on GiftMessage and GoogleAnalytics in code of Core module (except string literals that are not real dependency). Looks like dependencies are redundant. May be problems are in dependencies test.

[mzeis]

@eleonova We have the same situation as @Landkeks: we never used GiftMessage or GoogleCheckout but used GoogleAnalytics.
I'd vote for removing the dependencies as there is no logical reason for this and given all the current refactoring the change may not be that big (see also message by @JoseHawkins, didn't check myself).

[davidalger]

@eleonova The Magento_Core module should have no dependencies other than to the Magento Framework and it's underpinning libraries. Having these dependencies on small pieces of functionality flies directly in the face of the stated goal to unravel the dependency mess which Magento 1.x has currently. This module is essentially a part of the Magento Framework, and we should be able to strip any functional module or functional group of modules away without breaking the Magento_Core or the Magento Framework.

[rtull]

@eleonova Google Checkout is discontinued as of last November. It should be dropped entirely. http://googlecommerce.blogspot.com/2013/05/an-update-to-google-checkout-for.html

[rgranadino]

My vote goes for decoupling, @davidalger put it pretty well.

[elenleonova]

To all, we know that GoogleCheckout is discontinued so we are going to delete it from M2. Other parts are still under planning process. Thanks for active participation in the discussion.

[saleemshafi]

hello, sorry to jump in this late, but some of the work that Elena is referring to as being "under planning" includes further refactoring of the Magento/Core module by moving more of the code there to the Magento Framework.. we've done some of that already, and have more planned.. not sure if we'll get all the way to what @davidalger refers to, but we're moving in that direction..

as for the specific dependencies that started this thread, all three of those dependencies are caused by the references to those modules in \Magento\Core\Model\Resource\Setup\Migration.php in the getCompositeModules() method. That qualifies them as true dependencies, but not "hard" dependencies meaning that the logic in Magento_Core will not break if those modules aren't available.

We should be able to make this clearer by explicitly marking these dependencies in the Magento_Core/module.xml file as type="soft"

[vpelipenko]

All described dependencies are removed. Magento_Core module also will be eliminated - this work is still in progress.