Skip to content

Customer Widget DOB error in line 127 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sepple opened this issue Feb 5, 2014 · 3 comments
Closed

Customer Widget DOB error in line 127 #492

sepple opened this issue Feb 5, 2014 · 3 comments
Assignees

Comments

@sepple
Copy link

sepple commented Feb 5, 2014

Magento\Customer\Block\Widget\Dob

public function getSortedDateInputs()
{
...
'/[^medy]/i' => '\1',
...
}

should be \0 instead of \1

@verklov
Copy link
Contributor

verklov commented Feb 14, 2014

@sepple , thanks for reporting this issue! We will create a ticket and place it to the product backlog.

@verklov verklov self-assigned this Feb 14, 2014
@verklov
Copy link
Contributor

verklov commented Feb 27, 2014

@sepple , the team reviewed the suggested change to the code and unfortunately we rejected your contribution. Below is the response from the team in details:

This is currently working as expected. If the recommended change is made as explained, the end result would be invalid html being produced for the dob.phtml template. Two extra / will be introduced following the closing div tags.
Here is a sample of what is expected:

<div><label for="month"><span>M</span></label><input type="text" id="month" name="Month" value="jan"></div>
<div><label for="day"><span>d</span></label><input type="text" id="day" name="Day" value="1"></div>
<div><label for="year"><span>yy</span></label><input type="text" id="year" name="Year" value="14"></div>

And here is the result with the suggested change: (Notice the extra and invalid / following the tags.)

<div><label for="month"><span>M</span></label><input type="text" id="month" name="Month" value="jan"></div>/
<div><label for="day"><span>d</span></label><input type="text" id="day" name="Day" value="1"></div>/
<div><label for="year"><span>yy</span></label><input type="text" id="year" name="Year" value="14"></div>

@verklov verklov closed this as completed Feb 27, 2014
@sepple
Copy link
Author

sepple commented Feb 28, 2014

Well you are right, I was working in my own theme where it was all inline elements, replaced the div with span elements. The problem seems to be bigger now. The Block class is linked to the template file using block layout style. If I want to keep the date format as is, I run into problems.
I will post a new request with a better change than I suggested here.

vpelipenko added a commit that referenced this issue Jul 27, 2015
[FearlessKiwis] Sprint 51: Bug fixes
magento-team pushed a commit that referenced this issue Mar 30, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issue:
- MAGETWO-57562: Sales functional tests fail against ECE 2.0.9 (wrong grand total price)
magento-engcom-team added a commit that referenced this issue Mar 26, 2019
…492

 - Merge Pull Request magento/graphql-ce#492 from sora1004/graphql-ce:magento2/graphql-ce_adjusted_test_coverage_set_billing_address
 - Merged commits:
   1. b5803c5
   2. 18cafdc
   3. eb2c414
   4. 594e556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants