-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Customer Widget DOB error in line 127 #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@sepple , thanks for reporting this issue! We will create a ticket and place it to the product backlog. |
@sepple , the team reviewed the suggested change to the code and unfortunately we rejected your contribution. Below is the response from the team in details: This is currently working as expected. If the recommended change is made as explained, the end result would be invalid html being produced for the dob.phtml template. Two extra / will be introduced following the closing div tags.
And here is the result with the suggested change: (Notice the extra and invalid / following the tags.)
|
Well you are right, I was working in my own theme where it was all inline elements, replaced the div with span elements. The problem seems to be bigger now. The Block class is linked to the template file using block layout style. If I want to keep the date format as is, I run into problems. |
[FearlessKiwis] Sprint 51: Bug fixes
Fixed issue: - MAGETWO-57562: Sales functional tests fail against ECE 2.0.9 (wrong grand total price)
Magento\Customer\Block\Widget\Dob
public function getSortedDateInputs()
{
...
'/[^medy]/i' => '\1',
...
}
should be \0 instead of \1
The text was updated successfully, but these errors were encountered: