Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Theme Activation #519

Closed
joejack22 opened this issue Mar 2, 2014 · 7 comments
Closed

New Theme Activation #519

joejack22 opened this issue Mar 2, 2014 · 7 comments

Comments

@joejack22
Copy link

Hello guys,

I am testing the new theme structure. I noticed that each theme has a theme.xml file. Based on this, I have created a new theme called magento_test under app/design/frontend and added the theme.xml file.

Under the backend I cannot see this theme under system->configurations->design. Furthermore, if I go to content themes and click the plus symbol to add a theme I can now see my test theme. However, if I try to activate that theme I get a "this field is required error".

After looking at the source code I see that the value for my theme is blank.

Can someone point me in the right direction on how to add new themes to Magento 2 or tell me if this is a bug. Do I have to initialize it some how?

@joejack22
Copy link
Author

Still hoping someone can help with this or tell me if this is a bug.

@0xpablo
Copy link

0xpablo commented Mar 3, 2014

I think it's a bug. I tried creating a new theme and It only appeared after a clean installation of Magento.

@joejack22
Copy link
Author

Thanks for confirming pablos93 that this is a bug! I have a clean install myself and I am not able to activate a new theme at all.

Maybe we can get this bug added to the que to get fixed soon?

@tanya-soroka
Copy link

Hello, I created a ticket for a team to review at this new issue you reported. We will update you once the team completes investigation. Thank you for reporting this!

@joejack22
Copy link
Author

Thanks @tanya-soroka !

magento-team added a commit that referenced this issue Mar 28, 2014
* Fixed bugs:
  * Fixed an issue with displaying product on the frontend when the product flat indexer is enabled
  * Fixed an issue with applying catalog price rules on the category level
  * Fixed an issue where the essential cookies like CUSTOMER, CART, and so on were not created in Google Chrome
  * Fixed an issue with placing orders by customers assigned to a VAT group
  * Fixed an issue with incorrect error message during registration, and inability for a shopper to ask for resending a confirmation email
  * Fixed an issue where the Catalog module resource Setup Upgrade logic was broken
* Modularity improvements:
  * Moved abstract Core models and related logic to the Magento/Model library
  * Moved the abstract DB logic and Core resource helpers to the Magento/DB library
  * Eliminated the Core\Model\App class
  * Moved the Magento Flag functionality to the library
  * Resolved dependency of the Catalog and related modules on the Review module
  * Moved indexers related logic from the Core module to the Indexer module
  * Moved the Inline translation and user intended translate functionality from the Core module to a separate Translation module
* Framework Improvements:
  * Covered Magento library components with unit tests:
     * Magento\Config
     * Magento\Convert
     * Magento\Controller
     * Magento\Data\Collection\Db
     * Magento\Mview
     * Magento\Url and Magento/Url.php
  * Covered Magento application components with unit tests:
     * Magento\Checkout\Model\Config
     * Magento\Checkout\Model\Observer
     * Magento\Checkout\Model\Type
     * Magento\Sales\Model\Config
  * Renamed LauncherInterface to AppInterface
* Improvements in code coverage calculation:
  * Updated the whitelist filter with library code for integration tests code coverage calculation
* GitHub requests:
  * [#512] (#512) -- Theme Thumbnails not showing
  * [#520] (#502) -- Corrected Search Engine Optimization i18n
  * [#519] (#519) -- New Theme Activation
* Customer Service usage:
  * Refactored the Log module to use Customer Service
  * Refactored the RSS module to use Customer Service
  * Refactored the Review module to use Customer Service
  * Refactored the Catalog module to use Customer service layer
  * Refactored the Downloadable module to use Customer service layer
@verklov
Copy link
Contributor

verklov commented Mar 28, 2014

@joejack22, our team has fixed the issue that you reported. The fix has just been released in version dev71. Thank you for your input in Magento product development!

@verklov verklov closed this as completed Mar 28, 2014
@magentoman2009
Copy link

Thank you!

magento-team pushed a commit that referenced this issue Aug 19, 2015
[Sky EPAM]  Inline JS Elimination from Storefront
magento-team pushed a commit that referenced this issue Apr 6, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issues:
- MAGETWO-58090: [Magento Cloud] - Intermittent HTTP ERROR 500 during checkout 
- MAGETWO-59024: [Github] Ship To section on Checkout's Review & Payments step, clears out the Ship To address on page reload
- MAGETWO-55447: Portdown MAGETWO-54718 down to M2.1.x branch
- MAGETWO-55662: Portdown MAGETWO-51428 down to M2.1.x branch
- MAGETWO-59209: [Github] Minicart item count is not updated if switch from https to http #6487 
- MAGETWO-56964: [GitHub] Validate attribute values #4881
magento-devops-reposync-svc pushed a commit that referenced this issue May 12, 2023
ACPT-1219: Fix Static Tests failures for application-Server PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants