-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @var $this comments to templates #52
Comments
Not the best idea because template may be used by several blocks. |
Most templates are used by only one block. I have requested this because I'd like to be able to ctrl click function calls like |
Anyway idea is bad. Just think, what will happen if somebody rewrites this block using Magento rewrite system? |
@FiveDigital @stalniy |
I know that |
The proposal was approved by the technical leads and included into Magento 2 coding standards. @FiveDigital , thank you for the proposal. |
…er/issues/29 magento2-login-as-customer/issues/29: Destroy impersonated customer sessions on admin logout.
Templates contain comments like this:
Adding @var $this comments enables code completion in our IDEs:
The text was updated successfully, but these errors were encountered: