-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By default Allow all access in .htaccess #533
Comments
Leave a comment |
@airbone42, thank you for your question! The team will investigate on the issue. We will get back to you once we have an answer to share with you. |
@airbone42, I just received the results of review for this issue. Below is the response:
We cannot accept the proposed change as the default configuration we use is the same default configuration for the web server, which is a recommended setting. We are closing this issue. |
HI @verklov, thanks for the feedback. You're right it's the default configuration, especially because of that there's no sense in setting it again in the .htaccess file. But as soon as you change that configuration in Apache Magento will now override it again by this .htaccess file! So if you want to protect your installation by ip or credentials (and I doubt we're the only agency who's protecting their testing installations that way) you have to modify core code (if we consider .htaccess as a core file). I hope you can check this once more, with all this new information. |
Let me talk to the developer once again and then respond to you. |
I would much rather see htaccess removed from core altogether. It should be provided as a .htaccess.sample only (or have the installer generate one simialar to how applications like Wordpress do it). As an integrator it requires us to break the rule of "don't touch core" when we deploy client sites that require changes to htaccess. Additionally it makes upgrades require that we inspect the htaccess for changes and manually merge those in. |
+1 @lazyguru Additionally many Magento installations run on nginx where a .htaccess file is quite useless. |
That's already very dangerous in Magento 1, so is there a chance that this will be changed?
Usually we set Allow/Deny-permissions by settings in the Apache-config, but this is totally overwritten by default in Magento and enables everyone to access the page, even if the server is just thought to be a staging server.
What's the reason for that?
The text was updated successfully, but these errors were encountered: