Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occur after upgraded to 2.1.0 CE from 2.0.4 CE #5426

Closed
davidbilly opened this issue Jul 3, 2016 · 19 comments
Closed

Error occur after upgraded to 2.1.0 CE from 2.0.4 CE #5426

davidbilly opened this issue Jul 3, 2016 · 19 comments
Labels
bug report Component: Setup Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@davidbilly
Copy link

davidbilly commented Jul 3, 2016

Steps to reproduce

  1. Install 2.0.4 CE
  2. Upgrade to 2.1.0 CE by composer update
  3. rm -rf var/cache/* var/page_cache/* var/generation/*
  4. php bin/magento setup:upgrade
  5. chown -R www-data:www-data .
  6. find . -type d -exec chmod 770 {} ; && find . -type f -exec chmod 660 {} ; && chmod u+x bin/magento

Expected result

  1. Get stable 2.1.0 CE system

Actual result

  1. Front-end : after add cart , not showing update counter on top right
  2. Reference :
    screen shot 2016-07-03 at 3 19 01 pm
  1. Back-end : Go invoice show Notice: Undefined index: base_grand_total in /vendor/magento/module-sales/Ui/Component/Listing/Column/Price.php on line 55
  2. Back-end : Go product > catelog > Filter bar missing
  3. Back-end : Go product > catelog > Cant access/edit product details.
  • Reference :
    screen shot 2016-07-03 at 5 24 43 am

screen shot 2016-07-03 at 3 23 05 pm

Please help. Thanks.

@andimov
Copy link
Contributor

andimov commented Jul 4, 2016

@davidbilly
Did you clean all kind of cache from server and browsers?
If you have varnish you need to restart it to.

@southerncomputer
Copy link
Contributor

southerncomputer commented Jul 4, 2016

yeah i'd wipe rm -rf var/view* var/di va/rcache var/page_cache
rm -rf pub/adminhtml pub/_cache pub/deployed_version.txt pub/frontend pub/_requirejs
then php bin/magento deploy:mode:set developer
then do php bin/magento setup:di:compile
php bin/magento setup:static-content:deploy

service php-fpm restart
service httpd restart
service varnish restart

clear browser cache and reload the page!

@davidbilly
Copy link
Author

davidbilly commented Jul 5, 2016

@andimov
Hi Thanks for reply. I dint install varnish cache on my server.
I able to solve problem 3) and 4)
Solution :
Step 1 : Enable dev mode on cloudflare & clear cloudflare cache.
Step 2 : clear Browser cache.

The problem 1) and 2) still occur.

After above problem solved, i encounter another few problem.
On product detail page :

  • Product images that i uploaded are missing on edit product details. But i can saw them on front-end.

screen shot 2016-07-05 at 10 18 38 am

screen shot 2016-07-05 at 10 19 11 am

screen shot 2016-07-05 at 10 22 17 am

@ComputerNorth
Copy link

I have the same error as you point out in problem 2, after upgrading from 2.0.6 CE to 2.1.0 CE:

Back-end : Sales --> Invoices shows Notice: Undefined index: base_grand_total in /vendor/magento/module-sales/Ui/Component/Listing/Column/Price.php on line 55

@BigBri41
Copy link

BigBri41 commented Jul 6, 2016

I had the same issue with this in two separate environments and for us it was more than just an inconvenience. A customer placed an order that was successfully charged to Paypal and the order never showed up in the magento backend. So basically we have an orphaned order and magento keeps trying to get the IPN info from Paypal and erroring out because the order doesn't exist. Here is what I had to do to fix the issue:

ALTER TABLE magento.sales_invoice_grid
ADD COLUMN base_grand_total DECIMAL(12,4) NULL DEFAULT NULL AFTER shipping_and_handling;

Apparently this column isn't getting created with the upgrade and is what was causing the issue for us. If your database name isn't magento, you'll have to change magento in the query above to whatever your database name is. After doing this, orders are creating successfully. Magento is still trying to get the information from Paypal for that orphaned order, but it isn't preventing any new orders from going through. Hope this helps someone.

@ComputerNorth
Copy link

That is the solution, thank you!

@Tellfjord
Copy link

This helped me with the invoice problem. Thanks BigBri41

@davidbilly
Copy link
Author

Thanks @BigBri41 This solve my 2) Back-end : Go invoice show Notice: Undefined index: base_grand_total in /vendor/magento/module-sales/Ui/Component/Listing/Column/Price.php on line 55
problem!

@davidbilly
Copy link
Author

davidbilly commented Jul 11, 2016

I faced another one issue :
screen shot 2016-07-11 at 11 49 07 pm

After i place order,the top right mini cart is show empty. But when i go to https://domain.com/checkout/cart/ i can see all of my order.

screen shot 2016-07-27 at 9 08 32 pm

Previous version(2.0.4), it will show notification and let user know how many order they placed.

Any solution for this?

@marvincaspar
Copy link

I have the same issue.

I would expect that the new field base_grand_total is added in an upgrade schema script and not in the install schema script.

@SchumacherFM
Copy link
Member

SchumacherFM commented Jul 27, 2016

We ran into the same issue. Pretty annoying.

Some one at Magento forgot to put that column base_grand_total into the Upgrade Schema script.

Do you guys run tests?

At least please fix it with the 2.1.1 release.

Edit: already in the dev branch. Thanks guys!

@GordonLesti
Copy link
Contributor

@davidbilly One of your problem Attention Something went wrong. is #5323

@davidbilly
Copy link
Author

davidbilly commented Jul 27, 2016

@GordonLesti Thanks Mate! After enable Review Module the infinite loop loading for review gone.
Refer : #5426 (comment)

Now i still have one serious issue, that after add item to cart on front-end, not updating the cart list/notification. It's blank :(
Refer : #5426 (comment)

Update : Mini cart empty issue fixed with #5003 & #5144

@BigBri41
Copy link

I think we were getting this error too. If I remember right, it was some type of javascript error. I used internet explorer to figure out where the problem was. If you go to tools, internet options, then click on the advanced tab and uncheck Disable Script debugging (other) and uncheck Disable script Debugging (Internet Explorer), then refresh the page, it should pop up any javascript errors. Can you give that a try and let us know what error you are getting if any please?

@shiftedreality
Copy link
Member

Hi @davidalger

I was not able to reproduce this on 2.0.9 -> 2.1.1 upgrade flow.

This bug was fixed in 1d4873b
And dev 7f5b644

Please create new issue if you experience any other problems.

Closed.

@sdasun
Copy link

sdasun commented Apr 1, 2017

I had the same issue, for me cloudflare magnification is the one who get the blame. Hope this information help some one who will have the same issue as I did :)

@NimishPawar
Copy link

Thanks @BigBri41 :)

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 22, 2017
@ChameleonDevil
Copy link

@bh-ref, thank you for your report.
The issue is already fixed in develop branch, 2.2.0

The issue Unexpected identifier about the welcome message (and not escaped ' characters are still present).

I have installed a new M2.3.5 installation where I have this same error - when trying to debug customer() at the knockout section of the header template at the welcome message it returns {} empty object.

        <!-- ko ifnot: customer().fullname  -->
        <span class="not-logged-in"
              data-bind='html:"<?= $block->escapeHtml($welcomeMessage) ?>"'></span>
        <?= $block->getBlockHtml('header.additional') ?>
        <!-- /ko -->

I am not sure if $block->escapeHtml() is supposed to output Welcome to X's site or Welcome to X\'s site, and then Knockout undo the escape in a sense?

#5426

Issue 5003 claims issue was fixed - I don't think so.
#5003

Difference here is that I do not have products in this database yet. Can someone please point me to where customer() gets populated , I need to figure out why customer() is empty object at that point.

@ChameleonDevil
Copy link

ChameleonDevil commented Sep 30, 2020

Ok so this issue is related to how knockout seems to not correctly handle (') single quote characters in some theme templates.

If your template has this:

<!-- ko ifnot: customer().fullname -->
<span data-bind="html:'<?= $block->escapeHtml($welcomeMessage) ?>'"></>
<!-- /ko -->

Change to this:

<!-- ko ifnot: customer().fullname -->
<span data-bind='html:"<?= $block->escapeHtml($welcomeMessage) ?>"'></>
<!-- /ko -->

Notice I swapped the single quote and double quote positions such that the double quotes are inside, so that in effect does this:

' " ' " '
Instead of:
" ' ' ' "

I am positive anywhere (other templates) where knockout data-bind is used with PHP escapeHtml() or where quote characters are present will have this issue.

sidolov pushed a commit to sidolov/magento2 that referenced this issue Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Setup Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests