Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST routing precedence #5553

Closed
nickmarx12345678 opened this issue Jul 8, 2016 · 7 comments
Closed

REST routing precedence #5553

nickmarx12345678 opened this issue Jul 8, 2016 · 7 comments
Assignees

Comments

@nickmarx12345678
Copy link

nickmarx12345678 commented Jul 8, 2016

Would like some clarification with regards to how URL matching on the rest API occurs on URL's that developers create in their routes.xml

For example if:
route1 = GET /V1/myResource/:customerId
route2 = GET /V1/myResource/:customerId/subResource

It's not clear if requesting the url /V1/myResource/12345/subResource will map to route1 with a customerId parameter of 12345/subResource or if it will map to route2 with a customerId parameter of 12345

Similar permutations of this would be helpful to know as well such as:
route1 = GET /V1/myResource/:customerId
route2 = GET /V1/myResource/subResource
route3 = GET /V1/myResource/subResource/:subResourceId

It's unclear which will be called with what argument if I request /V1/myResource/subResource

@nickmarx12345678 nickmarx12345678 changed the title Rest routing precedence REST routing precedence Jul 8, 2016
@nickmarx12345678
Copy link
Author

Alternatively, it would be very helpful to add some sort of debug logging indicating what method is being routed to for a given rest request url

@choukalos
Copy link

Please move your question to the Forum or Stack Exchange.

@piotrekkaminski suggestion to improve debugging.

@nickmarx12345678
Copy link
Author

@choukalos -- where would be the correct place to request improvements to the official documentation?

@mbrinton01
Copy link

@tanberry Please advise

@tanberry
Copy link

Thanks @mbrinton01 . Hi @nickmarx12345678 , please do share your thoughts and suggestions (and maybe even a PR with some contributions!) to our docs. For more info, see http://devdocs.magento.com/guides/v2.1/contributor-guide/contributing_docs.html.

You can also click on the "Edit this page on GitHUb" link at the top of every page in devdocs.magento.com (excluding auto-generated Swagger docs).

And, @keharper is our API writer, hit him up, please. ;-)

@vkorotun vkorotun removed the PS label Aug 4, 2016
@piotrekkaminski piotrekkaminski removed their assignment Aug 22, 2016
@mbrinton01
Copy link

@nickmarx12345678 please let us know if this issue can be closed or you need additional support.

@mbrinton01 mbrinton01 self-assigned this Sep 28, 2016
@nickmarx12345678
Copy link
Author

Close it

On Wed, Sep 28, 2016, 5:01 AM Mark Brinton notifications@github.com wrote:

@nickmarx12345678 https://github.com/nickmarx12345678 please let us
know if this issue can be closed or you need additional support.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5553 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLisUuJ6WhYB3p3Ir09aP7nu6YWHH1lks5qulcVgaJpZM4JIaZj
.

magento-engcom-team pushed a commit that referenced this issue Apr 11, 2020
MQE-2046: remove deprecated entities usages in MFTF tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants