Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPC not working in standard theme as global_notices block is not cacheable #558

Closed
airbone42 opened this issue Apr 23, 2014 · 3 comments
Closed

FPC not working in standard theme as global_notices block is not cacheable #558

airbone42 opened this issue Apr 23, 2014 · 3 comments
Assignees
@verklov

Comments

@airbone42
Copy link

The PageCache Observer method processLayoutRenderElement calls $layout->isCacheable() which returns false in the standard theme as the global_notices block is not cacheable. Therefore the full page cache does not work with the standard theme.
@airbone42
Copy link
Author

Besides that a lot of string still refer to the directory "full_page_cache", which is now configured to be "page_cache" and should be read from the configuration everywhere.

@verklov verklov self-assigned this Apr 23, 2014
@verklov
Copy link
Contributor

verklov commented Apr 23, 2014

@airbone42, thank you for reporting this issue! We placed a ticket in the backlog and will get back to you once we resolve it.

@verklov
Copy link
Contributor

verklov commented Jun 2, 2014

@airbone42, looks like this issue was fixed while fixing its duplicate internally. By now the team could not reproduce it. The fix was deployed to GitHub in versions dev77-dev78. We are closing this issue. Thank you again for your contribution!

@verklov verklov closed this as completed Jun 2, 2014
magento-team pushed a commit that referenced this issue Aug 31, 2015
@sivaschenko
Merge pull request #558 from magento-firedrakes/bugfixes49
84c18e3 
[Firedrakes] Sprint 49 bugfixes
magento-team pushed a commit that referenced this issue Apr 26, 2016
@sdwright
Merge pull request #558 from magento-fearless-kiwis/develop
b8d0abb 
[FearlessKiwis] Sprint 64-b: Bug fixes
magento-engcom-team added a commit that referenced this issue Apr 9, 2019
@magento-engcom-team
ENGCOM-4708: Add API functional tests for ApplyCouponToCart functiona…
4db8d00 
…lity #558

 - Merge Pull Request magento/graphql-ce#558 from dmytro-ch/graphql-ce:issue/479-test-coverage-apply-coupon-to-cart
 - Merged commits:
   1. bb7be7a
   2. 149dec1
   3. 0724b1c
   4. 2131a21
   5. 8c6ea9f
   6. fd0ebf8
magento-engcom-team pushed a commit that referenced this issue Apr 9, 2019
@naydav
ENGCOM-4708: Add API functional tests for ApplyCouponToCart functiona…
1d0e0ad 
…lity #558
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 8, 2023
@andimov
Merge pull request #558 from magento-performance/ACPT-1500
682f51e 
 ACPT-1500: Enable NewRelic monitoring for Application Server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@airbone42 @verklov