Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog product images - Do not removing from file system #564

Closed
ihor-sviziev opened this issue Apr 30, 2014 · 5 comments
Closed

Catalog product images - Do not removing from file system #564

ihor-sviziev opened this issue Apr 30, 2014 · 5 comments
Assignees
@verklov

Comments

@ihor-sviziev
Copy link
Contributor

When we importing new image file and removing old files we have old image in our file system, but link to that image is removing from DB.

In Media attribute backend model we have removing link to file from DB, but haven't removing it from file system.

When we have 100k+ products and make product import frequently, disk space is really fast ends.

This issue is also reproducing in Magento 1.
@verklov verklov self-assigned this May 5, 2014
@verklov
Copy link
Contributor

verklov commented May 5, 2014

@igor-svizev, thank you for reporting this issue to us! We now have it in the backlog. We will get back to you once the team investigates and resolves it.

magento-team added a commit that referenced this issue Jun 6, 2014
@magento-team
2.0.0.0-dev81
d895f13 
* Framework improvements:
  * Covered the following Magento application components with unit tests:
      * `SalesRule/Model/Observer`
      * `SalesRule/Helper/*`
      * `SalesRule/Model/Plugin/*`
      * `SalesRule/Model/System/Config*`
      * `Sales/Model/Config.php`
      * `Sales/Model/Download.php`
      * `Sales/Model/Quote.php`
  * Covered the following Magento lib form elements with unit tests:
      * `lib/Magento/Framework/Flag.php`
      * `lib/Magento/Framework/Escaper`
      * `lib/Magento/Framework/Event`
      * `lib/Magento/Framework/Logger`
      * `lib/Magento/Framework/Util`
      * `lib/Magento/Framework/Registry.php`
      * `lib/Magento/Framework/Backup/Media`
      * `lib/Magento/Framework/Backup/NoMedia`
      * `lib/Magento/Framework/Archive`
      * `lib/Magento/Framework/Translate.php`
  * Created Service API for Magento_Catalog module:
      * AttributeSet service
      * AttributeSetGroup service
      * ProductLinks service
      * ProductType service
* Payments Improvements:
  * Resolved a performance issue with Merchant Country selector under Payment Methods settings
  * Removed the PayPal Payments Pro Payflow Edition payment solution
  * Removed the Saved Credit Card payment method
* Added the following functional tests:
  * Delete Admin User
  * Delete Backend Customer
  * Delete Product UrlRewrite
  * Downloadable Product Creation
  * Update Simple Product
  * Update Tax Rule
  * Update Tax Rate
  * Suggest Searching Result
* Fixed bugs:
  * Fixed an issue where the Create Order page title was not correct when scrolling down was performed
  * Fixed the concurrent test running in MTF
  * Fixed an issue where product custom options were merged incorrectly
  * Fixed an issue where customer group discount was not applied for bundle products
  * Fixed an issue where it was impossible to  create a refund for the PayPal Exprecch Checkout Payflow Edition if captured from the PayPal admin
  * Fixed an issue where adding customer review caused an error in system.log
  * Fixed an issue where  the Manage Stock option was automatically reset to No after changing the Stock Availability option
  * Fixed an issue where the recurring profile attributes where displayed for a product when they were not included in the product attribute set.
  * Fixed an issue where a fatal error appeared in some cases on attempt to add a product to  cart when FPT was enabled
  * Fixed an issue where back in stock product alert emails showed HTML markup
  * Fixed an issue where the Refresh Statistics link on the Sales Report page redirected to the frontend after setting  Add Store Code to Urls to Yes
  * Fixed an issue where the selected bundle options price was included to the price displayed in the MAP popup
  * Fixed an issue where the wrong allowed countries list was used in Checkout
  * Fixed an issue where configurable products with out of stock associated simple products were displayed in layered navigation
  * Fixed an issue where configurable products lost options  after being duplicated using the Save and Duplicate button
  * Fixed issues with simple product custom options where it was impossible to import them from a product page and they were not duplicated correctly using the Save and Duplicate button
  * Fixed an issue where it was impossible to create a customer on the backend in a single store mode
  * Fixed an issue where reviews created on the backend appeared with the Guest status
  * Fixed an issue where it was impossible to add an image for a configurable product variation during editing
* Processed GitHub requests:
  * [#539] (#539) The "{config.xml,*/config.xml}" pattern cannot be processed
  * [#564] (#564) Catalog product images - Do not removing from file system
  * [#256] (#256) Unused file app\code\core\Mage\Backend\view\adminhtml\store\switcher\enhanced.phtml
  * [#561] (#561) Bugfix Magento\Framework\DB\Adapter\Pdo\Mysql::getForeignKeys()
  * [#576] (#576) Change Request for InvokerDefault::_callObserverMethod()
@verklov
Copy link
Contributor

verklov commented Jun 6, 2014

@igor-svizev, the team has fixed this issue. The fix is available in version dev81 we have just deployed.

@verklov verklov closed this as completed Jun 6, 2014
@phillbooth
Copy link

Use this plugin http://www.magentocommerce.com/magento-connect/image-clean.html

@tzyganu
Copy link
Contributor

tzyganu commented Nov 12, 2014

@phillbooth Did you read the name of this repo? It says Magento 2

@aohorodnyk
Copy link
Contributor

@tzyganu it's correct, but for Magento 2 fix pushed to Magento2 repo, but @ihor-sviziev have question about Magento 1 too. @phillbooth said solution for Magento 1 and that good.

magento-team pushed a commit that referenced this issue Oct 21, 2015
Merge pull request #564 from magento-troll/MAGETWO-41796
5202113 
[Merchant Beta] MAGETWO-41796: Unable to import or export products with multi-select attributes
magento-team pushed a commit that referenced this issue Apr 26, 2016
Merge pull request #564 from magento-mpi/MAGETWO-52116
2087543 
[MPI] Bugfix
magento-engcom-team added a commit that referenced this issue Apr 17, 2019
@magento-engcom-team
ENGCOM-4769: [Checkout coverage] setGuestEmailOnCart mutation #564
692ee87 
 - Merge Pull Request magento/graphql-ce#564 from magento/graphql-ce:set-guest-email-mutation
 - Merged commits:
   1. ed0dd32
   2. 70b6a9e
   3. b307f7a
   4. 5b85e5d
   5. c8cdc96
   6. 58fa5d4
   7. 44b99de
magento-engcom-team pushed a commit that referenced this issue Apr 17, 2019
@naydav
ENGCOM-4769: [Checkout coverage] setGuestEmailOnCart mutation #564
d3c7d49
magento-devops-reposync-svc pushed a commit that referenced this issue Dec 4, 2023
@andimov
Merge pull request #564 from magento-performance/ACPT-1587
a495fed 
ACPT-1587: Send GraphQl errors to New Relic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aohorodnyk @ihor-sviziev @tzyganu @phillbooth @verklov