Skip to content

Why use private for message ? #6

Closed
@stephpy

Description

@stephpy

On this class:

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Checkout/Model/Type/Onepage.php

Why $_customerEmailExistsMessage is defined as private, there is no setter and _customerEmailExistsMessage is setted from constructor statically.

The only one possibility we have to change this message is to play with i18n.

Is there a reason ? I think this property should be protected. No ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions