Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why use private for message ? #6

Closed
stephpy opened this issue Mar 2, 2012 · 1 comment
Closed

Why use private for message ? #6

stephpy opened this issue Mar 2, 2012 · 1 comment

Comments

@stephpy
Copy link

stephpy commented Mar 2, 2012

On this class:

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Checkout/Model/Type/Onepage.php

Why $_customerEmailExistsMessage is defined as private, there is no setter and _customerEmailExistsMessage is setted from constructor statically.

The only one possibility we have to change this message is to play with i18n.

Is there a reason ? I think this property should be protected. No ?
@magento-team
Copy link
Contributor

Hi stephpy. Thanks for the feedback.

It appears that there was no specific reason to make it private. It has been changed to protected (will be rolled out with one of the next code update).

@florinelchis florinelchis mentioned this issue Jun 4, 2012
Closed
@SunshineTech SunshineTech mentioned this issue Jun 27, 2012
Closed
@hackin88 hackin88 mentioned this issue Feb 13, 2013
Closed
@hidonet hidonet mentioned this issue Feb 20, 2013
Closed
@ryaan-anthony ryaan-anthony mentioned this issue Mar 23, 2013
Closed
@SunshineTech SunshineTech mentioned this issue Dec 5, 2013
Closed
@maksek maksek mentioned this issue Dec 27, 2013
Closed
@drexlma drexlma mentioned this issue Apr 1, 2014
Closed
@drexlma drexlma mentioned this issue Jun 12, 2014
Closed
@leeyisoft leeyisoft mentioned this issue Jun 14, 2014
Closed
@tarikQT tarikQT mentioned this issue Sep 20, 2014
Closed
@WouterSteen WouterSteen mentioned this issue Oct 3, 2014
Closed
@magicento magicento mentioned this issue Oct 13, 2014
Closed
@MihaiCraciun MihaiCraciun mentioned this issue Nov 12, 2014
Closed
This was referenced Nov 22, 2014
Closed
Closed
Closed
@Crustymd Crustymd mentioned this issue Dec 11, 2014
Closed
@aishwaryacedcoss aishwaryacedcoss mentioned this issue Dec 12, 2014
Closed
@askwhyweb askwhyweb mentioned this issue Dec 18, 2014
Closed
maksek pushed a commit that referenced this issue Dec 26, 2014
@vpelipenko
Merge pull request #6 from magento-qmt/develop
9ec1d8f 
[Mavericks] Re-factor end-to-end search tests and fix symlinks while factory generation
@sivajik34 sivajik34 mentioned this issue Jan 2, 2015
Closed
@shivkumarsingh7 shivkumarsingh7 mentioned this issue Jan 5, 2015
Closed
@mattisbusycom mattisbusycom mentioned this issue Jan 16, 2015
Closed
@rgauny rgauny mentioned this issue Jan 23, 2015
Closed
This was referenced Jan 24, 2015
Closed
Closed
@SKovbel SKovbel mentioned this issue Jan 31, 2015
Closed
@jayantakr1 jayantakr1 mentioned this issue Feb 17, 2023
Closed
5 tasks
@salah11172 salah11172 mentioned this issue Mar 1, 2023
Closed
5 tasks
@technicalrajni technicalrajni mentioned this issue Mar 18, 2023
Closed
5 tasks
@angelo983 angelo983 mentioned this issue Mar 27, 2023
Closed
5 tasks
@kisfelix kisfelix mentioned this issue Apr 4, 2023
Closed
5 tasks
@yohangwak yohangwak mentioned this issue May 5, 2023
Open
5 tasks
@makkoff makkoff mentioned this issue May 30, 2023
Closed
5 tasks
This was referenced Jun 14, 2023
Closed
Closed
@xtremevision xtremevision mentioned this issue Jun 26, 2023
Closed
5 tasks
@lfluvisotto lfluvisotto mentioned this issue Jul 5, 2023
Closed
5 tasks
@Hexmage Hexmage mentioned this issue Jul 11, 2023
Closed
5 tasks
@dandrikop dandrikop mentioned this issue Jul 15, 2023
Closed
5 tasks
Open
5 tasks
@chammedinger chammedinger mentioned this issue Oct 16, 2023
Closed
5 tasks
Closed
5 tasks
@iranimij iranimij mentioned this issue Nov 21, 2023
Closed
5 tasks
@chernenm chernenm mentioned this issue Dec 4, 2023
Closed
6 tasks
@nabeelfocus nabeelfocus mentioned this issue Jan 3, 2024
Closed
5 tasks
@dronerdk dronerdk mentioned this issue Feb 22, 2024
Closed
5 tasks
@nomis11uk nomis11uk mentioned this issue Apr 9, 2024
Closed
5 tasks
@AndeeKnitsLTD AndeeKnitsLTD mentioned this issue May 1, 2024
Closed
5 tasks
@engcom-Dash engcom-Dash mentioned this issue May 8, 2024
Open
5 tasks
@ghost ghost mentioned this issue May 13, 2024
Closed
5 tasks
@alicedfisheye alicedfisheye mentioned this issue May 14, 2024
Closed
5 tasks
@malikabid malikabid mentioned this issue May 21, 2024
Closed
5 tasks
@dverkade dverkade mentioned this issue May 28, 2024
Open
5 tasks
@shakeblue shakeblue mentioned this issue May 31, 2024
Closed
5 tasks
@aurel5542 aurel5542 mentioned this issue Jun 29, 2024
Closed
5 tasks
@FabXav FabXav mentioned this issue Oct 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephpy @magento-team