Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDistinct is not distinct in Tax Model #616

Closed
mszterlingfsite opened this issue Jul 16, 2014 · 2 comments
Closed

getDistinct is not distinct in Tax Model #616

mszterlingfsite opened this issue Jul 16, 2014 · 2 comments
Assignees

Comments

@mszterlingfsite
Copy link

as example:

https://github.com/magento/magento2/blob/master/app/code/Magento/Tax/Model/Resource/Calculation.php

Line 106 getDistinct()
$select = $this->_getReadAdapter()->select();

should read
$select = $this->_getReadAdapter()->select()->distinct(true);

@verklov
Copy link
Contributor

verklov commented Aug 5, 2014

@mszterlingfsite, thank you for reporting this issue! I assigned it to the PO responsible for taxes and created a ticket in our internal backlog. We will get back to you once we have an update.

@verklov
Copy link
Contributor

verklov commented Sep 5, 2014

The team renamed the method, so we assume the issue was resolved now. We are closing this ticket. Thank you for contributing to Magento product development! Looking forward for your new bug reports!

@verklov verklov closed this as completed Sep 5, 2014
joanhe pushed a commit that referenced this issue Sep 22, 2015
magento-team pushed a commit that referenced this issue May 13, 2016
mmansoor-magento pushed a commit that referenced this issue Nov 25, 2016
Bugs
- MAGETWO-60908 Image role can't be updated
- MAGETWO-60299 Sample Data Test Failure: NavigateProductEntityTest
magento-engcom-team added a commit that referenced this issue Apr 22, 2019
…nctionality #616

 - Merge Pull Request magento/graphql-ce#616 from vovsky/graphql-ce:issue-605-test-coverage-Add-simple-product-to-cart
 - Merged commits:
   1. 4fcf7ed
   2. 8afaf80
   3. 8c34f6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants