Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Datepicker/calendar control does not use the store locale #6350

Closed
heldchen opened this issue Aug 26, 2016 · 19 comments
Closed

Frontend: Datepicker/calendar control does not use the store locale #6350

heldchen opened this issue Aug 26, 2016 · 19 comments
Assignees
@joachimVT
Labels
bug report Component: Translation Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@heldchen
Copy link
Contributor

heldchen commented Aug 26, 2016 •
edited
Loading

the frontend datepicker control (for example for the DOB field) is not localized: month names, day names and week start date are all using en_US.

Preconditions

  1. Magento 2.1.0 CE
  2. a non-en_US language pack is installed, which contains the translated month and weekday names, assuming de_DE for this issue
  3. frontend store is set to use this language/locale

Steps to reproduce

  1. Admin > Settings > Configuration > Customer > Customer Configuration > "Show Date of Birth: Require"
  2. Admin > Settings > Configuration > General > Locale Options > "First Day of Week: Monday"
  3. clear cache / rebuild static assets if needed
  4. in the frontend, edit your account and use the datepicker of the DoB control

Expected result

  1. the month names in the dropdown are translated
  2. the weekday names are translated
  3. the week starts with monday

Actual result

  1. the month names are in english
  2. the weekday names are in english
  3. the week starts with sunday
@heldchen heldchen changed the title Datepicker/calendar control does not use the store locale Frontend: Datepicker/calendar control does not use the store locale Aug 26, 2016
@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 29, 2016
@sevos1984
Copy link
Contributor

Thanks for reporting, intrnal ticket MAGETWO-57733

@sevos1984 sevos1984 assigned sevos1984 and unassigned sevos1984 Aug 30, 2016
@antboiko antboiko mentioned this issue Sep 16, 2016
Closed
@lfritsche
Copy link

@sevos1984
is there any update about this issue?
Our customers are not happy with the unknown date-formatting and I would need a solution quiet soon.
Thank you!

@robinkanters
Copy link

@sevos1984 any progress? it's been almost half a year now

@tmelnichuk
Copy link

tmelnichuk commented Feb 23, 2017 •
edited
Loading

@lfritsche @robinkanters Seem's like adding block Magento\Framework\View\Element\Html\Calendar to the layout of required page resolves this problem (Magento 2.1.2 CE)

So I've added app/design/frontend/<Vendor>/<theme>/Magento_Customer/layout/customer_account_edit.xml with next content:

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceContainer name="content">
            <block class="Magento\Framework\View\Element\Html\Calendar" name="html_calendar" as="html_calendar" template="Magento_Theme::js/calendar.phtml" before="-"/>
        </referenceContainer>
    </body>
</page>

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Component: Translation labels Sep 11, 2017
@joachimVT joachimVT mentioned this issue Sep 26, 2017
Merged
4 tasks
@joachimVT
Copy link

Working on this ticket.

@joachimVT joachimVT mentioned this issue Sep 26, 2017
Merged
4 tasks
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80096

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 4, 2017
@magento-engcom-team
Copy link
Contributor

@heldchen, thank you for your report.
We've created internal ticket(s) MAGETWO-57733 to track progress on the issue.

@magento-engcom-team
Copy link
Contributor

Hi @heldchen the issue has been fixed in #11067 by @joachimVT . The fix will be available in 2.2.1

@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line ready for backport labels Oct 6, 2017
@joachimVT joachimVT mentioned this issue Oct 9, 2017
Closed
4 tasks
@digvijay2017
Copy link

This issue still exists in Magento 2.2.1 . I have checked Today.

magento2-1-1

@rikterbeek rikterbeek mentioned this issue Nov 14, 2017
Closed
@peterjaap
Copy link
Contributor

@okorshenko please re-open this issue. I can confirm this issue still exists on 2.2.1.

@okorshenko
Copy link
Contributor

Hi @heldchen. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1353 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 7, 2018
@peterjaap
Copy link
Contributor

peterjaap commented Mar 23, 2018 •
edited
Loading

As far as I can see this is the only relevant commit; 72e9e07

And that is already in (at least) 2.2.3. But it still does not work.

@nntoan
Copy link
Contributor

nntoan commented May 1, 2018 •
edited
Loading

I can confirm that it still does not work in 2.2.3. Should we reopen the issue?

@vishalnyati
Copy link

Calendar translation is not working for me yet.. I started with 2.1.7 and updates every releases now i have upgraded it to 2.2.3 but still issues is same.( almost an year) Calendar is not translated in any other locale other than English. Is there any chance it will fix anytime soon in future ..

@peterjaap
Copy link
Contributor

@magento-engcom-team ?

@navinbhudiya
Copy link

@okorshenko I can confirm that it still does not work in 2.2.3. Should we reopen the issue?

@navinbhudiya
Copy link

@magento-engcom-team any update? any quick solution?

@peterjaap
Copy link
Contributor

Not fixed in 2.2.6.

@HariS3ldon
Copy link

Waiting for the fix in the core, we made a module that temporarily fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimVT joachimVT

Labels
bug report Component: Translation Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests