Cant't get cart items in block - quote object empty

[bartoszkubicki]

Preconditions

1. Magento 2.1 CE, php 7.0

Steps to reproduce

1. In custom module I added block, which should check if provided product is in cart.
2. Block is added properly, although method doesn't work.
3. When I try to check if my product is in cart I get info that cart is empty (but in fact it is not). That is my class:

namespace [vendor]\SkinHelper\Block\Catalog\Product;

use \Magento\Catalog\Api\Data\ProductInterface;
use \Magento\Checkout\Model\Session;
use \Magento\Framework\View\Element\Template;
use \Magento\Framework\View\Element\Template\Context;

/** Class provides method to check if given product is in cart
 * @universal
 */
class IsInCart extends Template
{

    /**
     * @var \Magento\Checkout\Model\Session
     */
    private $checkoutSession;



    /**
     * Di.
     * @param \Magento\Checkout\Model\Session $checkoutSession
     * @param \Magento\Framework\View\Element\Template\Context $context
     * @param array $data
     */
    public function __construct(
        Session $checkoutSession,
        Context $context,
        array $data
    )
    {
        parent::__construct($context, $data);

        $this->checkoutSession = $checkoutSession;
    }



    /**
     * Method check if provided product is in cart of current customer.
     * Doesn't work dynamically.
     * TODO: There is a bug actually in magento connected with session and full page cache
     * TODO: More details: https://github.com/magento/magento2/issues/3294
     *
     * @param \Magento\Catalog\Api\Data\ProductInterface $product
     *
     * @return bool $inCart
     */
    public function isInCart(ProductInterface $product)
    {
        $productId = $product->getId();
        $cartItems = $this->checkoutSession->getQuote()->getAllVisibleItems();
        $itemsIds = array();
        foreach ($cartItems as $cartItem) {
            $itemsIds[] = $cartItem->getProduct()->getId();
        }

        return in_array($productId, $itemsIds);
    }


    /**
     * Method counts items now available in cart.
     * TODO: There is a bug actually in magento connected with session and full page cache
     * TODO: More details: https://github.com/magento/magento2/issues/3294
     *
     * @return int $cartDataCount
     */
    public function countItemsInCart()
    {
        $cartItems = $this->checkoutSession->getQuote()->getAllVisibleItems();
        $cartItemsCount = count($cartItems);

        return $cartItemsCount;
    }

1. That's my call for these methods:

`isInCart($_product); ?>

helper([vendor]\SkinHelper\Helper\Test')->isInCart($_product) ?>`

As you can see I was trying the same thing with helper (called from helper), but it failed.

1. I was trying also the same way on \Magento\Checkout\Model\Cart and it also didn't worked.
2. The strangest thing is that the same logic placed and called as controller (by url) works and returns correct output.

Expected result

1. Of course, method in block called inside template returns correct result.

Actual result

1. When I dump $itemsIds it is empty, so no elements can be retrieved. Products are present in minicart, as well as in quote table as well.
2. Method works in controller but not inside block or helper called from template. What is even more strange the same method in helper called from controller works.

[bartoszkubicki]

I think problem may lay in cache, especially Full page cache.

[SerhiyShkolyarenko]

@bartek9007 there is a problem in your code

$cartItems = $this->checkoutSession->getQuoteId();
...
foreach ($cartItems as $cartItem) {...

$cartItems never will be an array. This code causes an exception for me. Could you specify the code version which works from controller?

[bartoszkubicki]

@SerhiyShkolyarenko you are right. I updated my question, I posted chunk of code I have been testing later. Of course, it will cause exception. Now there is a code in question which actually works only when full page cache disabled.

[SerhiyShkolyarenko]

@bartek9007 please also provide DownloadableSampleUrlProviderInterface code for clean experiment.

[bartoszkubicki]

@SerhiyShkolyarenko
DownloadableSampleUrlProviderInterface defines another method, which is implementing this interface. This method helps to get downloadable sample for provided downloadable product and has nothing to do with IsInCart() method - they are not called together.

I will update it to the code I have now - and it is whole class and also doesn't work.

[SerhiyShkolyarenko]

@bartek9007 I made some minor changes to have your code compiled and injected to controller. Patch with all my changes is attached. Also I disabled page cache to check how it works in debugger.
I ran compilation and the code worked properly: I opened product page twice to check.
The code returned false when cart was empty and the code returned true, when I added product to cart. This check was performed on the latest develop branch. Does it work the same for you?
Github6392.zip