Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie Restriction Mode Overlay is cached by Varnish #6455

Closed
bka opened this issue Sep 1, 2016 · 2 comments
Closed

Cookie Restriction Mode Overlay is cached by Varnish #6455

bka opened this issue Sep 1, 2016 · 2 comments
Assignees
@bka
Labels
bug report Component: Framework/Cache Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Release Line: 2.1

Comments

@bka
Copy link
Contributor

bka commented Sep 1, 2016

Ok, here is another one related to full page caching with varnish. It's related to these other issues: #6441, #5596. Using cookie restriction mode in combination with varnish does not work, because this block is not declared as non-cachable. Having cookie restriction mode enabled, customer is asked by a dialog to accept cookies. This cookie notice block contains the question: "We use cookies to make your experience better. To comply with the new e-Privacy directive, we need to ask for your consent to set the cookies. Learn more." and gives you a button to "Allow Cookies". Using varnish it might happen that this dialog won't appear anymore. Here is how:

Steps to reproduce

  1. Tested on Magento 2.1 CE
  2. Use Varnish as Full Page Cache
  3. Enable Cookie Restriction Mode under General->Web->Default Cookie Settings
  4. Flush Cache
  5. Visit Store Front
  6. Accept Cookies by clicking on Allow Cookies button
  7. Flush Cache
  8. Visit Store Front (Your acceptance will be cached)
  9. Delete your Cookies
  10. Visit Store Front again (I'm an unkown visitor now with no cookies)

Expected result

  1. Cookie notice block should appear again

Actual result

  1. Cookie notice block does not appear (and never will for anybody until you clear cache again)
bka added a commit to teamneusta/magento2 that referenced this issue May 20, 2017
@bka
changed user dependend isUserNotAllowSaveCookie condition in notice.p…
058f287 
…html to fix varnish caching issue magento#6455
@bka bka mentioned this issue May 20, 2017
Merged
magento-team pushed a commit that referenced this issue May 24, 2017
@ishakhsuvarov
MAGETWO-69372: Cookie Restriction Mode Overlay should not be cached b…
a5d868a 
…y Varnish #6455 #9711

 - Merge Pull Request #9711 from teamneusta/magento2:issue-6455
magento-team pushed a commit that referenced this issue May 24, 2017
@vrann
MAGETWO-69372: Cookie Restriction Mode Overlay should not be cached b…
e1ce3ec 
…y Varnish #6455 #9711
@ishakhsuvarov
Copy link
Contributor

Reopening, as fix for 2.1 is not implemented yet.

@ishakhsuvarov ishakhsuvarov reopened this May 29, 2017
@magento-team magento-team added Release Line: 2.1 Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Framework/Cache develop labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69372

hostep pushed a commit to hostep/magento2 that referenced this issue Sep 2, 2017
@bka @hostep
Backport PR-9711 for Magento 2.1 - changed user dependend isUserNotAl…
7a611cc 
…lowSaveCookie condition in notice.phtml to fix varnish caching issue magento#6455

(cherry picked from commit 058f287)
@hostep hostep mentioned this issue Sep 2, 2017
Merged
@magento-engcom-team magento-engcom-team added Release Line: 2.1 Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Framework/Cache develop Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Sep 11, 2017
rganin pushed a commit to magento-arcticfoxes/magento2 that referenced this issue Dec 16, 2020
@fascinosum
Merge pull request magento#6455 from magento-trigger/MC-39893
18a712a 
[TR] Revert composer2 changes in mainline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bka bka

Labels
bug report Component: Framework/Cache Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Release Line: 2.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bka @magento-team @veloraven @ishakhsuvarov @magento-engcom-team