Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link at checkout not working for "What Is PayPal?" #6477

Closed
gazzaf opened this issue Sep 2, 2016 · 9 comments
Closed

Link at checkout not working for "What Is PayPal?" #6477

gazzaf opened this issue Sep 2, 2016 · 9 comments
Assignees
Labels
bug report Component: Payment Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@gazzaf
Copy link

gazzaf commented Sep 2, 2016

At the checkout the built-in link What is PayPal opens an empty pop-up window. This is bad for customers as the link is supposed to gain their confidence. Using IE11 the window shows the 404 page but is completely blank using Firefox and Chrome.

Screenshot of checkout page:

magento-paypal1

Screenshot of pop-up after clicking on "What is PayPal?":

magento-paypal2

Config: Magento 2.1.0
Theme: Luma (default, unedited)
Payment method: PayPal Website Payments Standard

How can this be fixed please?

@andimov
Copy link
Contributor

andimov commented Sep 5, 2016

@gazzaf
Thank you for reporting this issue!
Please, format this issue according to the Issue reporting guidelines.

@gazzaf
Copy link
Author

gazzaf commented Sep 5, 2016

I've uninstalled Magento 2.1.x because of the enormous number of bugs and slowness that make it unfit for production and "upgraded" to 1.9.x. Sorry.

@dyushkin dyushkin added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Payment and removed Progress: needs update labels Sep 13, 2016
@dyushkin
Copy link
Contributor

Hi @gazzaf! Thank you for your report, we've create internal ticket MAGETWO-58327 to fix this issue.

@H3dz
Copy link

H3dz commented Nov 23, 2016

Quick fix:

In:

  • vendor/magento/module-paypal/view/frontend/web/template/payment/payflow-express.html
  • vendor/magento/module-paypal/view/frontend/web/template/payment/paypal-express-in-context.html
  • vendor/magento/module-paypal/view/frontend/web/template/payment/paypal-express.html

Replace
<a data-bind="attr: {href: getPaymentAcceptanceMarkHref()}, click: showAcceptanceWindow"

With
<a data-bind="attr: {href: getPaymentAcceptanceMarkHref()}" target="_blank"

Run:

  • rm -rf pub/static
  • php bin/magento setup:static-content:deploy

@michaeldyl520
Copy link

Please rewirte paypal-express-abstract.js

app/design/frontend/Magento/theme/Magento_Paypal/web/js/view/payment/method-renderer/paypal-express-abstract.js
in line 43:
change
$(event.target).attr('href') 
to
$(event.target).parent().attr('href')

You can resolve it.

@viktym
Copy link
Contributor

viktym commented Apr 3, 2017

Correct fix should be
app/design/frontend/Magento/theme/Magento_Paypal/web/js/view/payment/method-renderer/paypal-express-abstract.js in line 43: change $(event.target).attr('href') to $(event.currentTarget).attr('href')

magento-team pushed a commit that referenced this issue Apr 26, 2017
- Fixed  jQuery selector of PayPal links
- Fixed js test that broke mouse event firing
@alena-marchenko
Copy link

Hi @gazzaf

Fix for MAGETWO-58327 is merged to develop branch, closing the issue.
Thank you!

@ifeltsweet
Copy link

Why is it still broken in 2.1.8 if it was merged to develop in April?

@Ctucker9233
Copy link

@alena-marchenko Which version of 2.1 will this fix finally be included in?

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Oct 14, 2017
mmansoor-magento pushed a commit that referenced this issue Feb 9, 2021
[Arrows] MC-39985: Request error when displaying content on CMS page of second website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Payment Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

10 participants