Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String wont translate: "Please enter a valid number in this field." #6622

Closed
jernejh opened this issue Sep 15, 2016 · 5 comments
Closed

String wont translate: "Please enter a valid number in this field." #6622

jernejh opened this issue Sep 15, 2016 · 5 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@jernejh
Copy link

jernejh commented Sep 15, 2016

Preconditions

  1. Using magento 2.1.1
  2. PHP 7.0

Steps to reproduce

  1. When trying to pay with Authorize.net module, string "Please enter a valid number in this field." won't translate, despite having the following lines in my csv file:

"Please enter a valid number in this field.","V to polje vnesite veljavno številko.",module,Magento_Catalog
"Please enter a valid number in this field.","V to polje vnesite veljavno številko.",module,Magento_Ui

Expected result

  1. The string "Please enter a valid number in this field." should translate the same as almost all other strings do.

Actual result

capture

@jernejh jernejh changed the title String wont translate: " String wont translate: "Please enter a valid number in this field." Sep 15, 2016
@quienti
Copy link
Contributor

quienti commented Sep 15, 2016

Already fixed in develop branch
Pull Request here : #5725

@davidalger
Copy link
Member

Closing as fixed in upcoming release. Please re-open if the bug persists on develop branch.

@Ctucker9233
Copy link

@davidalger this appears to have not been fixed in the 2.1.2 release. Is it safe to manually merge the fixed code on a 2.1.2 production environment?

@magento-team magento-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 2, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-72249

@marilena6
Copy link

I am using 2.1.4 and facing this issue, is there a patch or anything?

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 6, 2017
magento-engcom-team pushed a commit that referenced this issue Feb 12, 2021
[Arrows] Fixes for 2.4 (pr123) (2.4-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants