Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvement: OrderInterface should have a getShippingAddress method #6919

Closed
phoenix-bjoern opened this issue Oct 7, 2016 · 6 comments
Closed
Assignees

Comments

@phoenix-bjoern
Copy link
Contributor

phoenix-bjoern commented Oct 7, 2016

As a developer who writes an order export for Magento2 you would expect that besides the getBillingAddress there would be also a getShippingAddress method. While all the [g/s]etShipping... methods exists in the Magento\Sales\Model\Order model (which is the actual implementation of the OrderInterface) those elementary shipping-address methods are not part of the API interface.

Example: $order is declared as type Magento\Sales\Api\Data\OrderInterface. Practically the code "$order->getShippingAddress()" works but from a declarative view the method does not exist in the API and the implementation therefore is technically wrong.

While it is understood that not all orders have a shipping address (virtual orders/goods) the majority of orders processed in ecommerce actually have a shipping address. So the shipping-address methods should become part of the OrderInterface like it is already the case for the billing-address methods.

@pboisvert
Copy link

Thanks Bjorn for the feedback. Will make sure the product owner for APIs sees this

@phoenix-bjoern
Copy link
Contributor Author

Thanks @pboisvert! already in touch with @choukalos :-)

@pboisvert
Copy link

yes--Chuck knows about this area but owned currently by @mbrinton01

@veloraven veloraven added the PROD label Oct 13, 2016
@mbrinton01 mbrinton01 self-assigned this Oct 13, 2016
@piotrekkaminski
Copy link
Contributor

@phoenix-bjoern would you be willing to contribute this as a PR?

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

@mbrinton01
Copy link

Tracking internally as MAGETWO-60017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants