Can't save order status label

[robmagento]

Preconditions

1. Magento 2.1.1 CE
2. nginx, PHP 7.0.10, MySQL 5.7.11

Steps to reproduce

1. Admin > Stores > Order Status > click on one from the list > try to add new labels for a certain store view > click save

Expected result

1. New labels should be stored in db.

Actual result

1. New label values are not stored in db

[AntonEvers]

The problem is that in \Magento\Sales\Controller\Adminhtml\Order\Status\Save::execute after order status load the order status is missing the label data.

\Magento\Framework\Model\ResourceModel\Db\AbstractDb::save checks if the data that was present on load is changed. It hasn't. But data is added. And that does not count in the isModified check there. So the order status is considered as not modified and the processNotModifiedSave is executed instead of updateObject

[AntonEvers]

@robmagento as a workaround you can edit the main label as well and save it with the store labels. Then edit it back once the labels are in place. This will work.

[AntonEvers]

I'll see if I can make a pull request so that this code will include the store values of the labels.

\Magento\Sales\Controller\Adminhtml\Order\Status\Save::execute

$status = $this->_objectManager->create('Magento\Sales\Model\Order\Status')->load($statusCode);

[robmagento]

Your workaround... works :). Thank you, I did not have the time to investigate this.

[AntonEvers]

There you go ;)

[SerhiyShkolyarenko]

@robmagento thank you for reporting. Internal issue is MAGETWO-59639

[SerhiyShkolyarenko]

@ajpevers thanks for a workaround!

[salelsol]

@ajpevers same issue, and afther change code works like a charm.

[swayoleg]

On 2.18 it the same

until Magento\Sales\Model\ResourceModel\Order\Status will extend the \Magento\Framework\Model\ResourceModel\Db\AbstractDb
NOT VersionControl
(\Magento\Framework\Model\ResourceModel\Db\VersionControl\AbstractDb)

[swayoleg]

the _afterSave doesnt executed when extention of resource model is from VersionControl

[swayoleg]

This fix still helps
54e50d6