-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing Slash in Product URLs No longer working #7040
Comments
In reference to issue magento#7040
@sitepodmatt thank you for your feedback. |
According to contributor guide, tickets without response for two weeks should be closed. |
Still issue is still not fixed in Magento 2.1.9. Seems like a very important one. If stores are indexed by Google with a trailing slash, one cannot simply migrate and contain the URL structure. This will be killing for rankings. Why has this not been fixed yet? We are now forced to change this in the vendor file with the risk that this will be overwritten on any update. |
B2B-1875: Cannot import table rates CSV when S3 Remote Storage is enabled
We imported an M1 store to a fresh M2 (develop branch) with Magento Data Migration Tools. My clients store used /abc-product/ as the product detail URLs, the information populated correctly, including request_path in url_rewrite (i.e. trailing slash present), however all URLs 404 when clicked.
In my opinion app/code/Magento/UrlRewrite/Controller/Router.php (L132) should not be right trimming trailing slashes before passing to UrlFinder, this is causing problems with product search engine URLs that use the trailing space variety (as M1 supports).
The admin panel allows one to specify 'Product URL suffix' for Catalog as / Which correctly causes the product URL rendering for category/search pages to contain the trailing slash, however those product pages 404, because the trailing slash is stripped and doesn't match anything request_path in url_rewrite.
Believe this should be ltrim only.
The text was updated successfully, but these errors were encountered: