Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt config is overwritten on Magento updates via composer #7196

Closed
mombrea opened this issue Oct 26, 2016 · 10 comments
Closed

Grunt config is overwritten on Magento updates via composer #7196

mombrea opened this issue Oct 26, 2016 · 10 comments
Assignees
Labels
Area: Frontend bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@mombrea
Copy link

mombrea commented Oct 26, 2016

This issue occurs on composer upgrades of Magento CE 2.x.x

Latest instance occurs in upgrade to Magento CE version 2.1.2

Steps to reproduce

  1. Configure your theme for Grunt in /dev/tools/grunt/config/themes.js
  2. Update Magento using composer

Expected result

  1. Magento should update but not overwrite configuration files

Actual result

  1. /dev/tools/grunt/config/themes.js is overwritten with the default version
@veloraven
Copy link
Contributor

@mombrea please identify which version of Magento you are running.

@mombrea
Copy link
Author

mombrea commented Oct 27, 2016

@veloraven Updated to indicate Magento 2 CE through version 2.1.2

@ghost
Copy link

ghost commented Oct 27, 2016

I have experienced this also several times, was not sure if it was a bug or not.

@tkacheva tkacheva added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 18, 2016
@tkacheva
Copy link

Internal issue MAGETWO-61147

@Igloczek
Copy link
Contributor

@omiroshnichenko described solution in #8910

  • Copy grunt-config.json.sample to grunt-config.json.
  • Copy dev/tools/grunt/configs/themes.js to dev/tools/grunt/configs/local-themes.js
  • Specify your themes config in dev/tools/grunt/configs/local-themes.js

@okorshenko
Copy link
Contributor

@mombrea the issue has been fixed in develop branch. Thank you for reporting the issue
@Igloczek thank you for the provided fix

@dakira
Copy link

dakira commented Nov 23, 2017

This is still a problem for Magento 2.1.10

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 23, 2017
@Igloczek
Copy link
Contributor

@dakira The fix was released with 2.2, but you can do a backport of my PR to 2.1-develop branch

@dakira
Copy link

dakira commented Nov 23, 2017

@Igloczek I spent two days on trying to get frontend less compilation to run with grunt for M 2.2 without success which is why I moved back to 2.1.

I would say a backport is a bit more involved than just your 4 commits. The whole grunt toolchain would have to be modified (5c76ada)

@Igloczek
Copy link
Contributor

Why would you like to backport toolchain from 2.2 to 2.1, if you just said it's not working for you?

IMO you are just trying to mix two separated topics together, while if your issue is really the one described in this issue (overwriting of you custom, working configuration), you should care only about backporting the content of .gitignore from #8910

magento-engcom-team pushed a commit that referenced this issue Nov 11, 2021
B2B-2069: Images from remote directory is throwing errors on lib/internal/Magento/Framework/Filesystem/Directory/Write.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants