Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento JMeter Performance Testing best practices #723

Closed
pmouawad opened this issue Nov 1, 2014 · 5 comments
Closed

Magento JMeter Performance Testing best practices #723

pmouawad opened this issue Nov 1, 2014 · 5 comments
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line improvement Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@pmouawad
Copy link

pmouawad commented Nov 1, 2014

Hello,
I reviewed the JMeter samples that you provide at:
https://github.com/magento/magento-performance-toolkit/tree/master/

First, let me say I find it great that you provide such tests which will improve Magento performances and introduce Performance Testing as a best practices.
Second I wanted to provide some feedback that I hope will be useful:
1/ Maintainability : You should not set Implementation on Http Request, leave it blank and set it in HTTP Request Defaults.
2/ Performance/Realistic Tests : Better use HttpClient4 than Java
3/ Performance : Replace Beanshell by JSR223 + Groovy + Use cache key, it performs 10 times better in terms of CPU
4/ Performance : In Assertions, instead of Contains, use Substring as you usually don't need regexp, it will perform way better in terms of CPU
5/ Performance/Maintainability : In "Simple Product 1 View(BrowsAddToCart)", use CSS/JQuery Extractor instead of XPath, it is more suitable for HTML and performs way better than XPath. Apply this everywhere you use XPath for HTML
6/ Performance/Maintainability : In "Checkout start(CustomerChkt)" use CSS/JQuery Extractor instead of Regexp Extractor, it is more maintainable for HTML and performs better
7/ Performance/Maintainability : Avoid XPath assertion like in Login(CustomerChkt), combine CSS/JQuery Extractor + Response Assertion using Variable
8/ Performance/Maintainability : Disable all Listeners, keep only Simple Data Writer that writes on error and use NON GUI Mode + CSV output
9/ In Test Plan you should check "Run tearDown thread Groups after shutdown of main threads"
10/ How come there is no "Think time", I think a realistic "Gaussian Timer" should be inserted as a child of Test Action with 0 Sleep . Doing so you can control precisely every pause your put.

More details can be found here:
http://www.ubik-ingenierie.com/blog/magento-performance-toolkit-and-jmeter-best-practices/
Regards
Philippe M.
@philmdot

@maksek
Copy link
Contributor

maksek commented Nov 3, 2014

Hi @pmouawad, thank you for sharing feedback. We will evaluate and improve our performance tests. Meanwhile - feel free to share feedback, and create pull requests.

@maksek maksek self-assigned this Nov 3, 2014
@pmouawad
Copy link
Author

pmouawad commented Nov 4, 2014

Hi,
It will be a pleasure, is there some public available Magento install where the JMX can be tested ?
Also which version should we submit PRs for ?
Thanks
Regards

@okobchenko
Copy link
Contributor

Hi @pmouawad.
Currently we don't host any public install of Magento2, so it can be testes only on your local installation.

All PR for Magento2 performance toolkit can be submitted to current repository.
PRs for Magento1.x toolkit can be sent here: https://github.com/magento/magento-performance-toolkit.

@maksek maksek added the PS label Nov 6, 2014
@maksek maksek removed the major-check label Jan 8, 2015
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-31542

@vpelipenko vpelipenko added MX and removed PS labels Feb 20, 2015
@vpelipenko vpelipenko added PS and removed MX labels Feb 23, 2015
okorshenko pushed a commit that referenced this issue Feb 7, 2017
[Mavericks] Update extended functional tests suite for Cloud plan
magento-engcom-team added a commit that referenced this issue Jun 21, 2019


 - Merge Pull Request magento/graphql-ce#723 from pmclain/graphql-ce:feature/set-payment-and-place-order-mutation
 - Merged commits:
   1. f73b752
   2. a5feb01
   3. a8c60a5
   4. 4397b4b
   5. 283b8dd
@VladimirZaets
Copy link
Contributor

Hi @pmouawad. Thank you for your report.
The issue has been fixed in #25719 by @serhiyzhovnir in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 26, 2019
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line improvement Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

7 participants