Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google API Tracking code missing single quote after account number #7549

Closed
ps202 opened this issue Nov 24, 2016 · 3 comments
Closed

Google API Tracking code missing single quote after account number #7549

ps202 opened this issue Nov 24, 2016 · 3 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ps202
Copy link

ps202 commented Nov 24, 2016

Tracking code displayed on website is missing a single code after the account number if Google API has been set through admin backend.

Preconditions

Magento 2.2.0-dev from github

Steps to reproduce

  1. Go to: Stores->Configuration->Sales->Google API
  2. Enter Account Number
  3. Save
    google_api

Expected result

  1. Tracking should be working.

Actual result

  1. Tracking does not work, single quote missing after account number in code:
<script>
//<![CDATA[
    (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
    (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
    m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
    })(window,document,'script','//www.google-analytics.com/analytics.js','ga');

    
ga('create', 'UA-1xxxxxxxxx1, 'auto');
ga('send', 'pageview');
    
//]]>
</script>
@ps202
Copy link
Author

ps202 commented Nov 24, 2016

Workaround (LOL): Add single quote after Account number...
google-workaround_2

@miakusha
Copy link
Contributor

miakusha commented Feb 3, 2017

Hi @ps202 thanks for report
We've created internal ticket MAGETWO-64142 to address this issue.

@miakusha miakusha added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 3, 2017
@miakusha miakusha removed their assignment Feb 3, 2017
magento-team pushed a commit that referenced this issue Apr 13, 2017
…ixes #7549 #9084

 - Merge Pull Request #9084 from sambolek/magento2:issue-7549
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants