-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel Case Directories Not Allowed in Module Package Names #79
Comments
@Prattski The contribution has been incorporated into the internal repository with deviations in the regular expression. Also, appropriate unit test has been implemented. Next time please supply code changes with corresponding unit/integration tests. Changes will be available upon one of the next code publications to the GitHub from the internal repository. Closing the ticket as complete. Thank you. |
Ok - I haven't done unit/integration tests before, but I'll try and learn what needs to be done (I should learn anyway). Do you happen to have a link to a good article/example of what unit/integration tests should be provided with contributions? |
https://wiki.magento.com/display/MAGE2DOC/Magento+Automated+Testing+Guide |
JS-337: [Configurable.JS] Preload all needed images
MAGETWO-66666: Adding a product to cart from category page with an ex…
…ot assigned to a shared catalog (#79)
I have been working on porting over some of my modules to Magento 2 to get a head start on Magento 2 module development. I was having a really difficult time getting the adminhtml menu items to display. I was following the example in the Mage_Cms module. I was getting an error that stated, "Param resource doesn't pass validation".
I posted it on Twitter, and @mzeis sent an example of his attempt with admin menus and it worked fine for him.
The only difference that I could tell between our code was the our module package names. My module was named "LyonsCore_Core" and his was "Emzee_BackendTest".
So, I tried to rename my module to "Lyonscore_Core" (no camel case in the package name), and then it worked just fine.
So, this is either a bug, or something needs to specify that camel case directories are not allowed as module package names.
The text was updated successfully, but these errors were encountered: