Skip to content

2.1.3 - Unable to change luma logo, default welcome message or footer copyright #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfsmith07 opened this issue Dec 23, 2016 · 21 comments
Closed
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@bfsmith07
Copy link

I upgraded from 2.1.2 to 2.1.3. After the upgrade my logo is back to the default luma one, my welcome message is the default and the footer copyright text is default. They still show correct in settings, but it does not display on my website.

Preconditions

I am using a custom theme on Magento 2.1.3. My setup is a follows:

  • Fedora Server 24
  • MySQL (MariaDB) 15.1
  • PHP 5.6.29

Steps to reproduce

I even tried installing a new version of Magento 2.1.3 from composer. After installation, i change the config to single store mode and changed my logo. Still on a brand new installation it didn't show my logo. It only shows the Luma one. Also it doesn't change the default welcome msg or footer copyright text.

Please help.

@bfsmith07 bfsmith07 changed the title 2.1.3 - Unable to change luma log, default welcome message or footer copyright 2.1.3 - Unable to change luma logo, default welcome message or footer copyright Dec 23, 2016
@cowmix88
Copy link

cowmix88 commented Dec 25, 2016

I'm having the same problem.

All my store views are using the default configuration settings and ignoring the website/store view configuration.

@Tonop
Copy link

Tonop commented Dec 25, 2016

The same issue.

@Ctucker9233
Copy link

Same here.

1 similar comment
@commcad
Copy link

commcad commented Dec 26, 2016

Same here.

@veloraven
Copy link
Contributor

@bfsmith07 thank you for your feedback.
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.

@vishveskrish
Copy link

Is there any patch or fix available ?

@indilo53
Copy link

Same issue here, even for default meta tags

@indilo53
Copy link

indilo53 commented Dec 27, 2016

To fix the logo, I edited Vendor/Theme/Magento_Theme/layout/default.xml :

<referenceBlock name="logo">
    <arguments>
        <argument name="logo_file" xsi:type="string">img/logo.png</argument>
    </arguments>
</referenceBlock>

created : Vendor/Theme/web/img/logo.png
created : Vendor/Theme/Magento_Email/web/logo_email.png

For the copyright, I created Vendor/Theme/Magento_Theme/templates/html/copyright.phtml with this content :

<small class="copyright">
    <div class="page-main cback">
        <span>Copyright &copy; 2016 MyCompany</span>
    </div>
</small>

For the welcome message, I created Vendor/Theme/Magento_Theme/templates/html/header.phtml with this content :

<?php
/**
 * Copyright © 2016 Magento. All rights reserved.
 * See COPYING.txt for license details.
 */

// @codingStandardsIgnoreFile

/**
 * @var \Magento\Theme\Block\Html\Header $block
 */
$welcomeMessage = $block->getWelcome();
?>
<?php switch ($block->getShowPart()):
    case 'welcome': ?>
        <li class="greet welcome" data-bind="scope: 'customer'">
            <!-- ko if: customer().fullname  -->
            <span data-bind="text: new String('<?php echo $block->escapeHtml(__('Welcome, %1!', '%1'));?>').replace('%1', customer().firstname)">
            </span>
            <!-- /ko -->
            <!-- ko ifnot: customer().fullname  -->
            <span data-bind="html:'CUSTOM WELCOME MESSAGE HERE'"></span>
            <!-- /ko -->
        </li>
        <script type="text/x-magento-init">
        {
            "*": {
                "Magento_Ui/js/core/app": {
                    "components": {
                        "customer": {
                            "component": "Magento_Customer/js/view/customer"
                        }
                    }
                }
            }
        }
        </script>
    <?php break; ?>

    <?php case 'other': ?>
        <?php echo $block->getChildHtml(); ?>
    <?php break; ?>

<?php endswitch; ?>

This is a lot of overhead but as a temporary fix it can be useful

@veloraven
Copy link
Contributor

We have created internal ticket MAGETWO-62737

@veloraven veloraven added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Dec 28, 2016
@mitch2k
Copy link

mitch2k commented Jan 5, 2017

Hi,

I have the same issue. Is there any timeline for a fix?
It seems that it also influences the favicon and watermark image. In fact, it looks like every setting under Content/Design/Configuration is affected.

@CreamyG31337
Copy link

This is something to do with enabling single store mode since after disabling it I can edit these fields and see the changes. See #7392

@mattcoz
Copy link

mattcoz commented Jan 10, 2017

I'm wondering if this is also the source of the problem I'm having with my Disable Module Output settings not being respected, since they're stored in the same way in the database.

@mattcoz
Copy link

mattcoz commented Jan 10, 2017

Following a clue from the other issue, I tried changing the scope value in the database from "websites" to "default" for all design attributes. It works! So, either the admin is incorrectly setting the scope in the database or the frontend is incorrectly picking up the "default" values instead of the "websites" values.

@BCW-Mike
Copy link

Note: Our site is in development so I'm not sure how feasible this solution will be for those with live and/or multiple stores.

I had the same issue and was able to correct it. When updating to 2.1.3 I had my site configured in single store mode. I disabled the single store mode and made logo/theme changes to the all the records (specifically Global) under the Design Configuration.

Disable single store mode:
Stores -> Configuration -> General -> Single-Store Mode -> No

Update logo:
Content -> Configuration ->Edit

Mike

@sergetumanov
Copy link

It really worked for me!!!! Thank you!

@ryrobbo
Copy link

ryrobbo commented Feb 7, 2017

Any updates on this issue? I'm not comfortable switching from single store mode so freely. I am still experiencing this bug after updating to 2.1.3 in January.

@sergetumanov
Copy link

sergetumanov commented Feb 9, 2017 via email

@mattcoz
Copy link

mattcoz commented Feb 9, 2017 via email

@Ctucker9233
Copy link

I can confirm 2.1.4 fixed this issue.

@mattcoz
Copy link

mattcoz commented Feb 10, 2017 via email

@veloraven veloraven removed their assignment Feb 22, 2017
@mrjcgoodwin
Copy link

Using 2.2 changing the message does not seem to work in Single Store Mode so either still isn't fixed or is broken again?

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jan 4, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Nov 10, 2022
ACPT-809: [Community] #36276 Long time request execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests