Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in variable name: billingAddressFromData vs. billingAddressFormData #7988

Closed
ekuusela opened this issue Dec 29, 2016 · 5 comments
Closed

Typo in variable name: billingAddressFromData vs. billingAddressFormData #7988

ekuusela opened this issue Dec 29, 2016 · 5 comments
Assignees
@arshadpkm
Labels
bug report Component: Checkout Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ekuusela
Copy link
Contributor

I don't know if this results in any errors but it certainly has the potential to cause some.

billingAddressFromData seems to be the one that is used:
https://github.com/magento/magento2/search?utf8=%E2%9C%93&q=billingAddressFromData&type=Code

billingAddressFormData is referred to only once:
https://github.com/magento/magento2/search?utf8=%E2%9C%93&q=billingAddressFormData&type=Code

It seems that that variable deals with form data so maybe it (and shippingAddressFromData) should be renamed.
@veloraven
Copy link
Contributor

@ekuusela thank you for your feedback.
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.
Please, also identify which version of Magento you are running.

@veloraven
Copy link
Contributor

We have created internal ticket MAGETWO-63300

@arshadpkm
Copy link
Contributor

I am in

arshadpkm pushed a commit to arshadpkm/magento2 that referenced this issue May 3, 2017
@arshad-codilar
magento#7988 Typo in billingAddressFromData changed
90ebccb
arshadpkm pushed a commit to arshadpkm/magento2 that referenced this issue May 3, 2017
@arshad-codilar
magento#7988 Added commnets in file checkout-data.js - added missing …
5bc1a22 
…index in checkoutData
@arshadpkm arshadpkm mentioned this issue May 3, 2017
Closed
4 tasks
arshadpkm pushed a commit to arshadpkm/magento2 that referenced this issue May 3, 2017
@arshad-codilar
magento#7988 Requested changes updated also reverted last updates in …
e3b22e4 
…checkoutData index
arshadpkm pushed a commit to arshadpkm/magento2 that referenced this issue May 3, 2017
@arshad-codilar
magento#7988 Changed typo pullled to pulled
73ac8c4
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
0c520a2 
…index, getters and setters. #9484

 - Merge Pull Request #9484 from arshadpkm/magento2:develop
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
6e86e50 
…index, getters and setters. #9484
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
d3b5486 
…index, getters and setters. #9484

 - fixed code style issue
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
1e87862 
…index, getters and setters. #9484

 - fixed code style issue
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
1884fd8 
…index, getters and setters. #9484

 - fixed merge conflict
magento-team pushed a commit that referenced this issue Jun 13, 2017
MAGETWO-68877: Issue #7988 Typo changed also added comments for each …
493bd49 
…index, getters and setters. #9484
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jun 14, 2017
ISSUE-9924 Merge remote-tracking branch 'upstream/develop' into issue…
322c357 
…-9924

* upstream/develop: (60 commits)
  Fix typo in comment
  Move prefix and suffix default values to a new PR
  MAGETWO-68877: Issue magento#7988 Typo changed also added comments for each index, getters and setters. magento#9484
  Revert "MAGETWO-69728: Fixes layered navigation options being cached using the wrong store id. magento#9873"
  MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found magento#7780
  Fix prefix, middle name and suffix were not prefilled in the checkout
  add middle name to checkout address html templates magento#8878
  Using Command output as message which actually provides more information for debugging than just the path
  Handling CLI error as a failure when validating composer.json file
  MAGETWO-69805: Return array of blocks as items instead of array of arrays magento#9157
  MAGETWO-69666: Return array of pages as items instead of array of arrays magento#9823
  MAGETWO-69723: Email to a Friend feature magento#9824
  MAGETWO-69539: PHP "soap" extension is not declared in composer.json but can be used by Magento modules
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-63054: [Catalog] MSRP field is not displayed for bundle products with fixed price
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  ...
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jun 14, 2017
Merge branch 'develop' into resizer
4dc7817 
* develop: (60 commits)
  Fix typo in comment
  Move prefix and suffix default values to a new PR
  MAGETWO-68877: Issue magento#7988 Typo changed also added comments for each index, getters and setters. magento#9484
  Revert "MAGETWO-69728: Fixes layered navigation options being cached using the wrong store id. magento#9873"
  MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found magento#7780
  Fix prefix, middle name and suffix were not prefilled in the checkout
  add middle name to checkout address html templates magento#8878
  Using Command output as message which actually provides more information for debugging than just the path
  Handling CLI error as a failure when validating composer.json file
  MAGETWO-69805: Return array of blocks as items instead of array of arrays magento#9157
  MAGETWO-69666: Return array of pages as items instead of array of arrays magento#9823
  MAGETWO-69723: Email to a Friend feature magento#9824
  MAGETWO-69539: PHP "soap" extension is not declared in composer.json but can be used by Magento modules
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-63054: [Catalog] MSRP field is not displayed for bundle products with fixed price
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories
  ...
@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Checkout develop labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-68877

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Checkout labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added develop Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

Fixed by @arshadpkm Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arshadpkm arshadpkm

Labels
bug report Component: Checkout Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ekuusela @magento-team @veloraven @arshadpkm @magento-engcom-team