Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportExport module produces PHP strict notices #80

Closed
FiveDigital opened this issue Sep 14, 2012 · 3 comments
Closed

ImportExport module produces PHP strict notices #80

FiveDigital opened this issue Sep 14, 2012 · 3 comments
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@FiveDigital
Copy link

The ImportExport module especially the model Mage_ImportExport_Model_Import_Entity_Product is accessing non existing array keys without checking them first. This leads to a system.log full of Notice: Undefined index:

Notice: Undefined index: sku  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1717
Notice: Undefined index: _type  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1240
Notice: Undefined index: _type  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1241
@barbazul
Copy link
Contributor

Also, there is a typo in the name of one of the media* attributes: _media_lable instead of _media_label in Mage_ImportExport_Model_Import_Entity_Product which has led me to a lot of confusion in the past.

@magento-team
Copy link
Contributor

Thanks for mentioning these code issues. We have quick-fixed them and covered with tests.

magento-team added a commit that referenced this issue Nov 12, 2012
@magento-team
2.0.0.0-dev30
0f2900a 
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * CAPTCHA
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
magento-team pushed a commit that referenced this issue Feb 6, 2015
@mazhalai
Merge pull request #80 from magento-ogre/develop-new
518964e 
[Ogres] Sprint 22 Contribution
@LifeAsBook LifeAsBook mentioned this issue Sep 10, 2015
Closed
@chaluvadiswamy chaluvadiswamy mentioned this issue Nov 3, 2015
Closed
@echh echh mentioned this issue Feb 17, 2016
Closed
@gnusmus gnusmus mentioned this issue Mar 1, 2016
Closed
magento-team pushed a commit that referenced this issue Mar 23, 2016
@uharbachou1
Merge pull request #80 from AnastasiaBuniakEPAM/JS-375
249756f 
Js 375: ProductVideo works incorect when Gallery updates
@jaimestuardo jaimestuardo mentioned this issue Apr 13, 2016
Closed
@salelsol salelsol mentioned this issue Jun 30, 2016
Closed
@lhsatch lhsatch mentioned this issue Jul 22, 2016
Closed
@refaelgold refaelgold mentioned this issue Oct 4, 2016
Closed
@Lielcw Lielcw mentioned this issue Oct 4, 2016
Closed
@nadshez nadshez mentioned this issue Nov 21, 2016
Closed
@art6495
Copy link

art6495 commented Nov 8, 2017

Hello,
I want to remove sku during product import using csv in magento, Can you please check it??

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 8, 2017
@primzonltd primzonltd mentioned this issue Feb 12, 2018
Closed
@ghost ghost mentioned this issue May 3, 2018
Closed
magento-engcom-team pushed a commit that referenced this issue Aug 27, 2018
@nikshostko
Merge pull request #80 from magento-epam/2.3-develop
fb0b234 
Merge 2.3-develop to EPAM-PR-2
@albsa albsa mentioned this issue Sep 26, 2018
Closed
@Microguru Microguru mentioned this issue Sep 27, 2018
Closed
@pskigen pskigen mentioned this issue Dec 14, 2018
Closed
magento-engcom-team pushed a commit that referenced this issue Feb 8, 2019
@tomreece
Merge pull request #80 from magento-pangolin/MC-4389
ee3bb63
@lfluvisotto lfluvisotto mentioned this issue Apr 7, 2019
Closed
@grassst grassst mentioned this issue Jan 3, 2021
Closed
@eBusinessAtlantique eBusinessAtlantique mentioned this issue May 20, 2021
Closed
@mtjweb mtjweb mentioned this issue Jun 25, 2021
Closed
5 tasks
@jorgb90 jorgb90 mentioned this issue Apr 29, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 15, 2022
Closed
5 tasks
@KhanBadshah588 KhanBadshah588 mentioned this issue Oct 6, 2023
Closed
5 tasks
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@barbazul @magento-team @FiveDigital @magento-engcom-team @art6495