Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving Category with existing image causes an exception #8069

Closed
BarnyShergold opened this issue Jan 7, 2017 · 6 comments
Closed

Saving Category with existing image causes an exception #8069

BarnyShergold opened this issue Jan 7, 2017 · 6 comments
Assignees
@nemesis-back
Labels
Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@BarnyShergold
Copy link

BarnyShergold commented Jan 7, 2017 •
edited
Loading

Preconditions

Using custom Ubuntu xenial vagrant-box, php7, apache

Have latest stable release of Magento 2.1.3 installed.
No 3rd part modules installed
Steps to reproduce

Steps to reproduce

  1. Create a new category an add an image
  2. Clear logs
  3. Edit category and save, without change any attributes

Expected result

  1. Category should save
  2. No errors in log

Actual result

  1. Category says it has saved, all details are as they should be.
  2. Exception.log states that there was a problem saving the images.

Notes

This seems to be an issue where on saving the, afterSave method on Magento\Catalog\Model\Category\Attribute\Backend\Image invoke the call to moveFileFromTmp, however as the file has already been moved on the original save, this caused moveFileFromTmp to throw an exception as it can't find the temporary file.
@dthampy dthampy added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 11, 2017
@dthampy
Copy link
Contributor

dthampy commented Jan 11, 2017

Internal jira ticket MAGETWO-63097 created

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 29, 2017
@magento-engcom-team
Copy link
Contributor

@BarnyShergold, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added 2.2.x Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 13, 2017
@nemesis-back
Copy link

I will work on it #SQUASHTOBERFEST 2017

nemesis-back added a commit to nemesis-back/magento2 that referenced this issue Nov 20, 2017
@nemesis-back
[Backport for 2.1 of magento#9904] magento#8069: Saving Category with…
5d1ec8b 
… existing image causes an exception
@nemesis-back
Copy link

@okorshenko you fixed this issue for 2.2 in this commit 0ac82eb
so I've just backported it to 2.1-develop

@nemesis-back nemesis-back mentioned this issue Nov 20, 2017
Merged
4 tasks
@okorshenko
Copy link
Contributor

Hi @nemesis-back
@osrecio is working on your PR review 👍

magento-team pushed a commit that referenced this issue Dec 13, 2017
@osrecio
MAGETWO-84432: [Backport for 2.1 of #9904] #8069: Saving Category wit…
0081481 
…h existing imag… #12368

 - Merge Pull Request #12368 from nemesis-back/magento2:backport/8069-category-save-image-exception
 - Merged commits:
   1. 5d1ec8b
magento-team pushed a commit that referenced this issue Dec 13, 2017
MAGETWO-84432: [Backport for 2.1 of #9904] #8069: Saving Category wit…
14293ce 
…h existing imag… #12368
@ishakhsuvarov ishakhsuvarov added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line and removed 2.1.x bug report labels Dec 13, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @BarnyShergold
We are closing this issue now as the fix has been delivered to 2.3, 2.2 and now 2.1-develop. You may refer to the linked commits to see the fix.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemesis-back nemesis-back

Labels
Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@BarnyShergold @veloraven @ishakhsuvarov @okorshenko @dthampy @VenkataUppalapati @magento-engcom-team @nemesis-back