Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image brackground #8799

Closed
delyriand opened this issue Mar 6, 2017 · 8 comments
Closed

Image brackground #8799

delyriand opened this issue Mar 6, 2017 · 8 comments
Assignees
@raumatbel
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@delyriand
Copy link

Preconditions

  1. Magento 2.1.3
  2. PHP 7

Steps to reproduce

  1. Edit view.xml file
    ex: theme-frontend-luma/etc/view.xml
  2. Add background color attribute to an image
<image id="related_products_list" type="small_image">
     <width>152</width>
     <height>230</height>
     <background>[250,247,247]</background>
</image>
  1. Clear cache and reload images.

Expected result

  1. Image with background

Actual result

  1. Product image always has a black background
    image

The problem comes from 2 methods:

  • Method Magento\Catalog\Model\ImageExtractor::processImageBackground : The method return a string array
  • Magento\Framework\Image\Adapter\AbstractAdapter::backgroundColor : If the color is not an integer, the background is ignored.
@korostii
Copy link
Contributor

Relevant part in the dev docs

@ArthurTransoftgroup
Copy link

ArthurTransoftgroup commented Jun 30, 2017 •
edited
Loading

@delyriand We've created internal ticket MAGETWO-70383 to address this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 30, 2017
@korostii korostii mentioned this issue Jul 3, 2017
Closed
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 4, 2017
@magento-engcom-team
Copy link
Contributor

@delyriand, thank you for your report.
We've created internal ticket(s) MAGETWO-70383 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@raumatbel
Copy link
Contributor

raumatbel commented Oct 31, 2017 •
edited
Loading

@magento-engcom-team can you assign me please?

This was referenced Oct 31, 2017
Merged
Merged
Merged
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83067

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83066

@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 4, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raumatbel raumatbel

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@delyriand @magento-team @veloraven @raumatbel @okorshenko @korostii @ArthurTransoftgroup @magento-engcom-team