Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can't subscribe to newsletter if you already have an account #8952

Closed
loomdecor opened this issue Mar 21, 2017 · 5 comments
Closed

You can't subscribe to newsletter if you already have an account #8952

loomdecor opened this issue Mar 21, 2017 · 5 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@loomdecor
Copy link

loomdecor commented Mar 21, 2017

Currently, if a user already has an account they cannot use the footer to sign up for email. This is a terrible user experience...nobody is going to go all the way into their account (or even KNOW to go there) to sign up for the newsletter. People do it from the footer or from popups.

Preconditions

  1. Any Magento version

Steps to reproduce

  1. Create a new account and don't sign up for newsletter
  2. Now use that same email to try to sign up for the newsletter

Actual result

  1. Observe that you receive an error message and you will not be subscribed to the newsletter when looking in the Newsletter Subscriber list in admin

Expected result

  1. User is signed up for the newsletter

I submitted this as a bug to Magento Enterprise support and was told this is "expected" behavior. Regardless of whether it is "expected", this is a terrible experience.

@grafikchaos
Copy link

grafikchaos commented Mar 22, 2017

I submitted this as a bug to Magento Enterprise support and was told this is "expected" behavior. Regardless of whether it is "expected", this is a terrible experience.

I agree. That is pretty bad. The error message should at least be helpful enough to explain why and what you should do to remedy the situation. Why can't it be handled by an observer that matches the subscriber to customer email address and link the two?

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 11, 2017
@magento-engcom-team magento-engcom-team added feature request Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 1, 2017
@adrian-martinez-interactiv4
Copy link
Contributor

adrian-martinez-interactiv4 commented Oct 31, 2017

In the issue description, it's not mentioned if the user that already has an account is logged in or not, when trying to subscribe himself from the footer or popups. I think this may be the reason why Magento Enterprise support has said this is the "expected" behaviour. From my point of view, we could split use cases this way:

  • Not logged in customer, introducing a non-existing email: As it is impossible to find out any information about who is entering the email, and there is no data related to introduced email, it's assumed email could belong to the person introducing the email, and there is no reason to reject subscription.
  • Logged in customer, introducing his own email: This way, as customer is already identified and he is trying to subscribe himself, the action to take when subscribing from the footer or popup should be the same as he did it from his account.
  • Not logged in customer, introducing an existing email related with a customer account: At this point, the customer has already registered that email, and should have full control about his personal data, including his subscription status. If I had an account registered, it would be weird if I unsubscribe myself from My Account (managing data that is only accessible and modifiable by myself), and then someone could change my subscription status only by introducing my email in the footer or a popup.

Aside of this, for a logged in customer, since he is able to subscribe himself to the newsletter, I think if it would be interesting to block logged in customers to subscribe in the footer and popups different emails than the registered one.

@magento-engcom-team
Copy link
Contributor

@loomdecor, thank you for your report.
We've created internal ticket(s) MAGETWO-84869 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 1, 2017
@okorshenko okorshenko removed the 2.1.x label Dec 14, 2017
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 29, 2018
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 29, 2018
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 29, 2018
…ount issue update changes as per suggestion
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 29, 2018
…ount issue update changes as per suggestion
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 30, 2018
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 30, 2018
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Oct 31, 2018
…ount issue update changes as per travis characters per line
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Nov 1, 2018
…ount issue update changes as per travis Failed asserting that two arrays are equal
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Nov 5, 2018
…ount issue update changes as per travis Failed change testsuite
ravi-chandra3197 added a commit to ravi-chandra3197/magento2 that referenced this issue Nov 5, 2018
…ount issue update changes as per travis change session message
@ravi-chandra3197 ravi-chandra3197 mentioned this issue Nov 12, 2018
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @loomdecor. Thank you for your report.
The issue has been fixed in #19164 by @ravi-chandra3197 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team added a commit that referenced this issue Dec 10, 2018
…ount issue #8952 -2.3 develop #19164

 - Merge Pull Request #19164 from ravi-chandra3197/magento2:patch-8952-2.3-develop
 - Merged commits:
   1. 78b694f
   2. ebfffe4
   3. b8941a8
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @loomdecor. Thank you for your report.
The issue has been fixed in #18912 by @ravi-chandra3197 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants