Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO SFTP - wrong constants in write method #9016

Closed
mb-tec opened this issue Mar 26, 2017 · 3 comments
Closed

IO SFTP - wrong constants in write method #9016

mb-tec opened this issue Mar 26, 2017 · 3 comments
Labels
bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@mb-tec
Copy link

mb-tec commented Mar 26, 2017

Preconditions

Magento 2.1.5

Steps to reproduce

File upload via SFTP to remote Server

Expected result

File upload works

Actual result

Exception thrown:
Notice: Use of undefined constant NET_SFTP_LOCAL_FILE - assumed 'NET_SFTP_LOCAL_FILE' in
.../magento/vendor/magento/framework/Filesystem/Io/Sftp.php on line 187

Wrong code: $mode = is_readable($source) ? NET_SFTP_LOCAL_FILE : NET_SFTP_STRING;
Should be: $mode = is_readable($source) ? \phpseclib\Net\SFTP::SOURCE_LOCAL_FILE : \phpseclib\Net\SFTP::SOURCE_STRING;

@veloraven
Copy link
Contributor

@mb-tec thank you for your report.
This issue has already been fixed in develop #6894
And we have internal ticket for fixing it in ver. 2.1 - MAGETWO-67470

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 16, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Sep 5, 2017
@rikwillems
Copy link
Contributor

This issue is still present in 2.1.8. I solved it with a preference that overrides the write method according to db17419
provided in #6894.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@mb-tec, thank you for your report.
The issue is already fixed in develop branch, 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants