Fixed phpseclib\Net\SFTP constants used in write() method #6894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@orlangur @vkublytskyi This is still broken in current dev branch. Any news? Can I help with something in order to get this merged? Regards! |
|
Hi @federivo, from https://github.com/magento/magento2/projects/3 it looks like things are heating up ;) Let's wait a little more time or you can try to ping some active community PR reviewer directly. |
|
Thank you @orlangur :) |
|
@federivo Thank you for the contribution. |
|
@vrann Any idea when this will make it into a release? |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 29, 2021
[Arrows] MC-24548: collect-totals API call not updating the selected shippingMethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
\Magento\Framework\Filesystem\Io\Sftpclass was modified to use an updated phpseclib library in commit 1383a49The write method uses the constants
NET_SFTP_LOCAL_FILEandNET_SFTP_STRINGthat worked just fine prior the library update. Since the library has changed, these constants are outdated and the write method throws this:Notice: Use of undefined constant NET_SFTP_LOCAL_FILE - assumed 'NET_SFTP_LOCAL_FILE' in /var/www/releases/release-0/vendor/magento/framework/Filesystem/Io/Sftp.php on line 187when trying to use it.
I modified the constants according the actual library used in Magento. Please refer to https://github.com/phpseclib/phpseclib/blob/master/phpseclib/Net/SFTP.php to verify correctness.
Regards.