-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug or Feature?] url_path attribute value is not populated for any product #9113
Comments
@MagePsycho thank you for your report. |
@veloraven This is happening for both CE & EE. |
It is important to notice that starting to use a url_path for products will have an important performance penalty. Currently it is already the case that when the url_key of a parent category changes, this affects the url_paths of all child categories. And the url_rewrite entries for these categories. If a url_path for products is the be kept current, it will be the case that when the url_key of a parent category changes, this affects the url_paths of all both child categories and child products, recursively. This in turn will have an effect on all their url_rewrite table entries. |
Started Investigating @okobchenko @ishakhsuvarov |
I am working on it at #mm17es |
Hello @MagePsycho Thank you for contribution and collaboration! Internal Magento team has investigated the issue and as result, all related internal tickets were closed with resolution
|
- added `@deprecated` tag to the `url_path` - details magento/magento2#9113
Hi @sdzhepa From my understanding the url_path is still being used for categories. A new magento 2.4.3-p1 installation includes url_path for categories, and are also generated when creating new categories and updating already existing ones. Can you refer to documentation about url_path and it being deprecated? |
@kasperth: there is no mention of categories in the opening post. This issue had to do with products. But you are both correct though, the |
Unfortunately there is a usage: ProductUrlPathGenerator.php#L79 This causes us URL-Rewrite bugs, because |
Yep, I still don't understand why that code hasn't been thrown away (maybe backwards compatibility for merchants that still have that field filled in in their database and rely on it somehow, who knows ...) Anyway, that's why you should keep the field empty in the database, if you want the (shameless advertisement: https://github.com/baldwin-agency/magento2-module-url-data-integrity-checker for a module to check for this) |
Preconditions
Steps to reproduce
url_path
value for that product as:SELECT * FROM catalog_product_entity_varchar WHERE attribute_id IN ( SELECT attribute_id FROM eav_attribute WHERE attribute_code IN ('url_path') AND entity_type_id = 4 ) AND entity_id = <product_id>
In fact there is no any value at all on product level for url_path.
Expected result
[product-url-key][product-suffix-from-setting]
Actual result
url_path
for any productQueries:
url_path
value for products?url_path
values for migrated products?The text was updated successfully, but these errors were encountered: